From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010037.outbound.protection.outlook.com [52.101.201.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570283E3D85 for ; Fri, 27 Mar 2026 10:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.37 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774609108; cv=fail; b=opk8zcDKYrBIQUmxtTliz55oD/6QhaQO0fRPi69c2XtOypfhemUbD8LqVp04zi8ytU0EeJXsAN7EGFD/lMl3xYCvjr+46eECW1ZwwNklLCGw/W0u4iqciuG1EEYRxT3jF9/YMplzaQXZ5vA6EpJ8/KQhODD+ZAgk4ubIQ3KdaWM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774609108; c=relaxed/simple; bh=tcEPoyq7wZtXjkp8LbQPWlJU88J1JqlzIR24c0VTZXY=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=A8FiYiy7LJsg61CDT/DlG/A/6NEbuNKUunn555fujCi7630HRQPBC3oaoL85AE8dCy6QwQ4TpigX1t1iDttxW5XdbMrOqtnLFwsyJkNgPBssYN9+jcJ1Sa005sFVkRV4MkoDMAx+gBzpZZ6DDj6o+aZNYiy4EiVz+MqgN2GniOQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=tBc3RCnW; arc=fail smtp.client-ip=52.101.201.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="tBc3RCnW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w8ZVuXd6wgGF2YXxCGT0Yd3mJoj3YKsif+fKZpmYcHk7WT+lV3SIbPaGjbF5c9BJpbncSV33ATwH/YnfA5yJg+abXiqU3UckJRXotsogMr/6/wheXljqN0z7nQcd4X9UIfngsBFAU3weHSgBYjjAWKk9Gebk/ZAMSfoYgWOaZEZabGrfbA4x3jILQ7jU/IQX15/z3fOo/srOUJdObIaBP103tw1Rp6VK60WGFbrJ0f+S8uVE8n2iNcPVK57rzeDehg6yrxZPvwS790a+zrAuHaDQd3LBWtmQOpJkQ7tabxlZAJJ6A7C97wGP5kXXjo/PHeD1LNi392IiHWdhq3lV8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OCabgjrq8VeGXDnwlpZCJNiVC+McqMlDpkqmbitWcGA=; b=FgW1pUA4d2ujwD45lGyyJzC1jg7cRW8DBqgcZss41FJvbNFXfqeoMYqUnxLGKeRBp6hd7EYKbQ8rYMxICxC2QLwi4aauISMlQW+Jeqs51VbJ/ffCQ1PvdhtGGzUjIaiI6rswlp94RjuT4Q9wS39C/ei6ZoswNJ2LgCb1PECqsmsOtulkD3HJqAZxODNtTPiei8GCivHI3/gmyT2vZKWcXilCRHIknX4Uj/coxlaANC4qmStq4+Vp/Ypr+Ae4wUOTKRknkYjAtZe99XLwT4KGMK8CKVvrU96VoQ5uydKI0d2TngSfzw4LUttXHD6sZYBH/m79t+6Xh7UHKAlwOPnFaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OCabgjrq8VeGXDnwlpZCJNiVC+McqMlDpkqmbitWcGA=; b=tBc3RCnW6TI/irJ9y3vXyxfIiDrK5pmjl/oY8A5tF1X3rkGwJ47gSAM+1z6HGGBkQdY33pPZm5KNXoBqkJUsWBt3yU//1EG7us+zU35+F6zIETIOF8+Thsde9FuvydJUCir9FGagCLxtmDDI03oY2ixM32eoUdoqynbsf5n9LIUtZaxvkSfFiWUShPwiBrb1jv4txo7QNstpglS88bobUfvzlLoPtGv9sgqZcWS3i9voBdQaIkb1a4YyLHKf5OlZlJJ+vmH4GNvsN7qJLw/Q0TdvS71ky04qKiYvh+KJuioyTrlMSUJt9QQVInQdOlDRI3YN29AO9uyeDfNMtx+Vuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by SA1PR12MB6847.namprd12.prod.outlook.com (2603:10b6:806:25e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.11; Fri, 27 Mar 2026 10:58:21 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9769.006; Fri, 27 Mar 2026 10:58:21 +0000 Date: Fri, 27 Mar 2026 11:58:14 +0100 From: Andrea Righi To: K Prateek Nayak Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection Message-ID: References: <20260326151211.1862600-1-arighi@nvidia.com> <20260326151211.1862600-2-arighi@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: ZR0P278CA0132.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::11) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|SA1PR12MB6847:EE_ X-MS-Office365-Filtering-Correlation-Id: 1240d7a5-7c9b-4e12-4c9f-08de8befc2c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: D2jw1iraxt/e+95fxgj5TD9WYAFByaUyRmol5HRMb150lsGybwcpmHQKBx40S+57hl33P1qnUj3FQqjjIF7cX6PiCIHFeJRQU8PGJVQfusd+MCLSvMc2o8ZvG+KL/HbBSkaW0tiX9zwy3o4T7OzIc5UwqN27HF5iuebxHXpHLMBykuH768j+bFk7aU2C2bCnrHXIHtIsMnWj5NN/9s6j0DoVv6Y3Mb4/WcEQD4lGqACKcxzwn58ajkrs6b/qM/oAu3eTMt36Zucnu1esu11ltglq1BlPkybzW0v1I85wry7o2QdhDf6Hpj8u1AfCxaq8kXvj4U5xQcvgFU82iy6GHFrv5GVQinUmNx3Mn74n621bUiBBq/3ttcU8kfQawp3p6gHgtLAxgidkGm+5bCQvo1dh8FMwju7pLEY2HCh3RKc2y+RYamJ55DvK/Ao8bDfGrF9qdb0x4iOLrApMZJEkljE1dr0g2/ulpexZ70dh5P3eTmT/dx1uOLJ1/oBn34nzF3iW4lcc/GS4qrmOYVmA9VEb+0pLcqKmKJB2/aA2LIEpfiuBjrVeIZ/PEeinzxdR592ynk4W4FCrCATmLk1ehhvzm0P2azGqJ3E7O0VQXR5K/UV7sPcFSS9o2yGnD0C2XTya4tc1jiflVtUNUAtsyjeVNSl3MwgHMG68neEMJUNSgnLJWyTGmMmqTTkcDGDVAbpvh4/wAcqANBAFDkxX9Anyl2WqkBFetFK1ycqhY1U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WQInTkE1uA7/rmbh/6Em/XhwHURTJdQ5YBvZKKh9dqUr2Bp+JENQMCGMsfr8?= =?us-ascii?Q?w730wqqFjkU8Ew/nH66A3OO+/mwLaKoZZ9gYAVu9bimC60fAajQxqb+U0IT+?= =?us-ascii?Q?gAU6ns7EL9zjm9ElBmkFEj9WB7mXYkW/lzVH4+i7jXPb8A6LhgOgPh7DAh2e?= =?us-ascii?Q?Hxe3c3QuM1DxVlHJsXsk0AE2sbHuu5M1P7zzYunajqCXsNheLIMo4X16crV9?= =?us-ascii?Q?jO6X+vz1ybZ4tW9hLmEC8TBQCj2BQJlZ0LuRmY1IgVtkRZNt6XmlgV3K2vpr?= =?us-ascii?Q?0+UKM+Ijnpt42ZAPWOdRtoHTSIKSV8ficIK3/Jh6g0eZtsOo0CbgmmlwMOhl?= =?us-ascii?Q?b6wyczXEtkKTZuaaXwVRzlw5aGXrArDRzqRfrjYpW9+lDBTKYibfQPce81s9?= =?us-ascii?Q?rJ2HIMkv3mZT0BHHpummUA7aZVrq3s8W6wQ9qppS523daWuaIJvQUxDrByvJ?= =?us-ascii?Q?gt9g+4NkybBMW4sifjs04WjWMkxOoZQm0r8YIo8x1q43PdGrmMPMiCZAhtff?= =?us-ascii?Q?dUxWDK6R5I6NiE04ElR7p4k7U3/JAQ99a0kcMVWEx1DBOTUyXgXuc47WBii/?= =?us-ascii?Q?741UfW0UgQingT7SOKlVevN3n/+wHpIWgPbmIkBEMSA/hbdJ67fIbI1pkeks?= =?us-ascii?Q?uDNPuoQIRzKewx6VnoFCtze9OwcM//AkP0gjU6tAPfE69JU77bJ1pFQqe1bb?= =?us-ascii?Q?CegZjYRdOjcKbIO3i9fNrnzirNTgIwtKtVt8CtpIw40Z9+h7xpHH4BVkNz4u?= =?us-ascii?Q?lZh2q3by6FWfO2Q5Qr+XCvsMcsb+wWDfKG0UR9QBsOcCICNXhV5umAfa/5W1?= =?us-ascii?Q?bBX90uz2zFp+iUt4uEge9QdwrYqIK1o8BPvwTIUeZReThf+Tl/8NRh2S/GyG?= =?us-ascii?Q?AEqvnt1vFSSbeemOqQgqzdkNk/sZ6HG5F5Hg1gTbVZHP0XW2il9vr/6xJmNR?= =?us-ascii?Q?oXkDRqVnJNaYnJST/yV8VZf7cpFZxYQlcl2/QlOxy0r/muYxCCKsyEy/2CuH?= =?us-ascii?Q?FBhpRxJPuAhHrF1KyDQ+kn+jMfwc1Grh5UKrfeLv5kfYHkj4ePhiRHHNJ/Kg?= =?us-ascii?Q?6uNUhkjcveuQHtOGhzYAe5/xu5K3Wprs8w7Z02fE8eTRsqzfXQ3B++nV57pE?= =?us-ascii?Q?b47DGeC4HeLyeCk/OvV6jN/J9y99HlMPiAKdINwTjKzx+zjmX8ZndzvgOMiP?= =?us-ascii?Q?7fn+omQ4bbvpNYBZO4dLVrR1e2BxaymhZdLzqe3Gv3MxdemvwTVrwzY2G+d+?= =?us-ascii?Q?5a8Sobm7jVjCJ2jKV6nHNIpR8JeKZQurFyKld/Se3KZTNz5mJ0NnqJtnOKRH?= =?us-ascii?Q?/t5p80xw9LQaKoZaJxYaXLuHqS7KiW1JhCIAFFJtmRddKv/3V2BAj96QFUtS?= =?us-ascii?Q?a9L4XWTnEC5DNqyVzVXDzzuZPwmNj1TN2kQqRWmiBKPwepFvoWEOhrHEKRe+?= =?us-ascii?Q?jM1ki3XFFfadXsQCrDdIRIaP8WmQQ4kUss8IiZX1BWPU3Bv+kxeDy5yw/hyI?= =?us-ascii?Q?pDjg000KalZ3dGSRytHPET56XmGuakEwWVnZ5l3IWhehQuRCOhrMS1PzVO+M?= =?us-ascii?Q?3sWuB9U6ZGKkifZKG9IFN3PXTqX8HMq6BamRi+AIyp4h2owS0FO/xP3UGDxB?= =?us-ascii?Q?DY+y5NwcjMTBARDy7s1YnXx7vSWhbSeOubwctQbw7HOG8v0QeWSGrxDu72uI?= =?us-ascii?Q?Xt7ad1PCQBnHipUmEpB4VwhfifPhCET4Wxjhdn+eL65uVUUoGN+V+5pTrgJU?= =?us-ascii?Q?cq21VRMHNg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1240d7a5-7c9b-4e12-4c9f-08de8befc2c1 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 10:58:21.6300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TgHc+B23ajfChCCySd5sfn99nuV8/O4QHy0LgosXVqPwLsqzhODTkkZzj2SIK062DXAbezVGL2jROxd8bvAn6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6847 Hi Prateek, On Fri, Mar 27, 2026 at 04:14:57PM +0530, K Prateek Nayak wrote: > Hello Andrea, > > On 3/26/2026 8:32 PM, Andrea Righi wrote: > > /* This CPU fits with all requirements */ > > - if (fits > 0) > > - return cpu; > > + if (fits > 0) { > > + if (prefer_idle_cores && on_idle_core) > > + return cpu; > > + if (!prefer_idle_cores) > > + return cpu; > > nit. > > Can the above two be re-wittern as: > > if (!prefer_idle_cores || on_idle_core) > return cpu; > > since they are equivalent. Oh yes, indeed. Thanks, -Andrea