Re: [PATCH RFC 2/2] tcg/aarch64/tcg-target.c.inc: Manual replace of I3310, I3313

[Jim MacArthur <jim.macarthur@linaro.org>]

On Fri, Mar 27, 2026 at 12:50:13PM +1000, Richard Henderson wrote:
> On 3/19/26 22:12, Jim MacArthur wrote:
> > These are not formats in themselves, but extra constants to OR in with
> > the existing ldst_imm format.
> > 
> > Signed-off-by: Jim MacArthur <jim.macarthur@linaro.org>
> > ---
> >   tcg/aarch64/tcg-target.c.inc | 64 +++++++++++++++++++++++++-------------------
> >   1 file changed, 36 insertions(+), 28 deletions(-)
> > 
> > diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc
> > index e9f86176d2..1f59d40a77 100644
> > --- a/tcg/aarch64/tcg-target.c.inc
> > +++ b/tcg/aarch64/tcg-target.c.inc
> > @@ -458,8 +458,9 @@ typedef enum {
> >       Ildst_imm_LDRVQ  = 0x3c000000 | 3 << 22 | 0 << 30,
> >       Ildst_imm_STRVQ  = 0x3c000000 | 2 << 22 | 0 << 30,
> > -    Ildst_imm_TO_I3310 = 0x00200800,
> > -    Ildst_imm_TO_I3313 = 0x01000000,
> > +    /* Additions to the ldst_imm format */
> > +    ldst_imm_to_sign_extend = 0x00200800,
> 
> "to sign extend" is wrong.
> 
> C3.3.10 Load/store register (register offset)
> 
> Perhaps ldst_imm_to_reg?
> 

Quite right, ldst_imm_to_reg does make more sense. Thanks for checking.

Jim