From: David Ahern <dsahern@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Taehee Yoo <ap420073@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] ip: add AMT support
Date: Sun, 24 Oct 2021 17:52:27 -0600 [thread overview]
Message-ID: <acab97fc-e134-47a5-0385-4dc3754a818e@gmail.com> (raw)
In-Reply-To: <20211024164526.2e1e9204@hermes.local>
On 10/24/21 5:45 PM, Stephen Hemminger wrote:
> On Sat, 23 Oct 2021 19:36:11 +0000
> Taehee Yoo <ap420073@gmail.com> wrote:
>
>> + while (argc > 0) {
>> + if (matches(*argv, "mode") == 0) {
>
> Try and reduce/eliminate use of matches() since it creates
Make that do not use matches. We are not accepting that for any new
command line arguments.
> lots of problems when arguments collides. For example "m" matches
> mode only because it is compared first (vs "max_tunnels").
>
next prev parent reply other threads:[~2021-10-24 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-23 19:36 [PATCH iproute2-next] ip: add AMT support Taehee Yoo
2021-10-24 23:45 ` Stephen Hemminger
2021-10-24 23:52 ` David Ahern [this message]
2021-10-25 14:03 ` Taehee Yoo
2021-10-24 23:46 ` Stephen Hemminger
2021-10-25 14:07 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acab97fc-e134-47a5-0385-4dc3754a818e@gmail.com \
--to=dsahern@gmail.com \
--cc=ap420073@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.