From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v2 2/2] printk_ringbuffer: Add sanity check for 0-size data
Date: Fri, 27 Mar 2026 17:08:47 +0100 [thread overview]
Message-ID: <acarj-BdV9Br0jPy@pathway.suse.cz> (raw)
In-Reply-To: <20260326133809.8045-2-john.ogness@linutronix.de>
On Thu 2026-03-26 14:44:02, John Ogness wrote:
> get_data() has a sanity check for regular data blocks to ensure at
> least space for the ID exists. But a regular block should also have
> at least 1 byte of data (otherwise it would be data-less instead of
> regular).
>
> Expand the get_data() block size sanity check to additionally expect
> at least 1 byte of data.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Looks good to me. It complements the 1st patch.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Tested-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2026-03-27 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 13:38 [PATCH printk v2 1/2] printk_ringbuffer: Fix get_data() size sanity check John Ogness
2026-03-26 13:38 ` [PATCH printk v2 2/2] printk_ringbuffer: Add sanity check for 0-size data John Ogness
2026-03-27 16:08 ` Petr Mladek [this message]
2026-03-27 16:07 ` [PATCH printk v2 1/2] printk_ringbuffer: Fix get_data() size sanity check Petr Mladek
2026-03-27 16:20 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acarj-BdV9Br0jPy@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.