All of lore.kernel.org
 help / color / mirror / Atom feed
From: "u.kleine-koenig@baylibre.com" <u.kleine-koenig@baylibre.com>
To: Cosmin-Gabriel Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
	 Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	 "magnus.damm" <magnus.damm@gmail.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	 "linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
	 "linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3>
Date: Fri, 27 Mar 2026 17:46:29 +0100	[thread overview]
Message-ID: <acax6VgK2hM2bjel@monoceros> (raw)
In-Reply-To: <TYRPR01MB1561945B6057A2ABFCF25C6788549A@TYRPR01MB15619.jpnprd01.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

Hello,

On Wed, Mar 25, 2026 at 01:24:40PM +0000, Cosmin-Gabriel Tanislav wrote:
> Sorry for replying to an old patch, but the context is relevant to my
> question.
> 
> I'm working on adding MTU3 support for a new platform, Renesas RZ/T2H.
> 
> From this patch, it is clear that new platforms should use
> #pwm-cells = <3>; as <2> is deprecated.
> 
> What I would like to clarify is whether existing platforms are also
> expected to be migrated from #pwm-cells = <2> to #pwm-cells = <3>.
> 
> My understanding is that changing the provider to #pwm-cells = <3> would
> break existing consumers that still specify only two cells in their PWM
> specifiers, since those references would then fail the checks inside
> of_phandle_iterator_next().

The conversion doesn't break dtbs, because in a single dtb consumer and
PWM device are consistent. So from my POV updating is fine.

> There are no existing consumers in-tree, but there might be out-of-tree
> ones that depend on #pwm-cells = <2>;.

That might happen for out-of-tree dts files that include the SoC's
.dtsi. IMHO it's ok to break these.

> If we're okay with the ABI breakage I can proceed with the changes for
> existing platforms too.

The reason that made me stop continuing the conversion myself is the
somewhat stuck discussion at
https://patchwork.ozlabs.org/project/linux-pwm/patch/crk42dsypmbyqk7avldghjq32vslmalfmmouwxzgtdci4agfhz@rkbmxj5z22fx/
.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2026-03-27 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-27 20:58 [PATCH] dt-bindings: timer: renesas,rz-mtu3: Use #pwm-cells = <3> Uwe Kleine-König
2025-05-28  5:18 ` Biju Das
2025-06-05 19:42 ` Rob Herring (Arm)
2025-06-16 13:08 ` Uwe Kleine-König
2025-07-31  9:41   ` Uwe Kleine-König
2025-07-31 13:50     ` Daniel Lezcano
2026-03-25 13:24 ` Cosmin-Gabriel Tanislav
2026-03-27 16:46   ` u.kleine-koenig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acax6VgK2hM2bjel@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=cosmin-gabriel.tanislav.xa@renesas.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.