All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Righi <arighi@nvidia.com>
To: Cheng-Yang Chou <yphbchou0911@gmail.com>
Cc: Tejun Heo <tj@kernel.org>,
	sched-ext@lists.linux.dev, David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>,
	Ching-Chun Huang <jserv@ccns.ncku.edu.tw>,
	Chia-Ping Tsai <chia7712@gmail.com>,
	Zqiang <qiang.zhang@linux.dev>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] sched_ext: Fix print_scx_info() build error on !CONFIG_EXT_SUB_SCHED kernels
Date: Fri, 27 Mar 2026 19:41:47 +0100	[thread overview]
Message-ID: <acbPa75X2LMsUUnv@gpd4> (raw)
In-Reply-To: <gunjxqantrttj335ai73vkvddqj5swkkfwvm5abkwprhiwjwwz@wktl537f5qim>

On Sat, Mar 28, 2026 at 02:21:42AM +0800, Cheng-Yang Chou wrote:
> Hi Tejun,
> 
> On Fri, Mar 27, 2026 at 07:18:59AM -1000, Tejun Heo wrote:
> > On Fri, Mar 27, 2026 at 01:35:53PM +0800, Cheng-Yang Chou wrote:
> > > Hi Tejun,
> > > 
> > > On Thu, Mar 26, 2026 at 04:09:15PM +0800, Cheng-Yang Chou wrote:
> > > > scx_task_sched_rcu() is only available when CONFIG_EXT_SUB_SCHED is
> > > > enabled. Wrap the call with #ifdef CONFIG_EXT_SUB_SCHED and fall back
> > > > to rcu_dereference(scx_root) for the non-sub-sched case, which is
> > > > semantically equivalent.
> > > > 
> > > > Fixes: 60d4b17e886a ("sched_ext: Choose the right sch->ops.name to output in the print_scx_info()")
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Closes: https://lore.kernel.org/oe-kbuild-all/202603261453.8kiJImYo-lkp@intel.com/
> > > > Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
> > 
> > Have you tried reproducing the problem? This is trivial to try to reproduce.
> > You aren't even doing the absoulte minimum. Before sending patches, read the
> > relevant code and reproduce the problem. I get that AI makes it easy to pump
> > up the volume but try to reduce the volume and improve the actual
> > contribution. Otherwise, I'll have to mostly ignore your emails.
> 
> Actually, I can reproduce this error on my end with the provided config.
> This patch does fix the issue.
> 
> I'll make sure to include the test log in my future submissions to
> avoid any confusion.
> 
> Here is the full log for this reproduction:

For what I see It should be fixed already in Tejun's branch:
git://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext.git

From kernel/sched/ext_internal.h:

#ifdef CONFIG_EXT_SUB_SCHED
...
static inline struct scx_sched *scx_task_sched_rcu(const struct task_struct *p)
{
        return rcu_dereference_all(p->scx.sched);
}
...
#else   /* CONFIG_EXT_SUB_SCHED */
static inline struct scx_sched *scx_task_sched_rcu(const struct task_struct *p)
{
        return rcu_dereference_all(scx_root);
}
...

Try with the for-7.1 branch.

-Andrea

  reply	other threads:[~2026-03-27 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  8:09 [PATCH] sched_ext: Fix print_scx_info() build error on !CONFIG_EXT_SUB_SCHED kernels Cheng-Yang Chou
2026-03-27  5:35 ` Cheng-Yang Chou
2026-03-27 17:18   ` Tejun Heo
2026-03-27 18:21     ` Cheng-Yang Chou
2026-03-27 18:41       ` Andrea Righi [this message]
2026-03-27 19:01         ` Cheng-Yang Chou
2026-03-27 19:48           ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2026-04-03  4:09 [PATCH] tools/sched_ext: Add scx_lib_init() to probe BPF prolog migrate_disable() behavior Cheng-Yang Chou
2026-04-03  4:09 ` [PATCH] sched_ext: Fix print_scx_info() build error on !CONFIG_EXT_SUB_SCHED kernels Cheng-Yang Chou
2026-04-03  4:14   ` Cheng-Yang Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acbPa75X2LMsUUnv@gpd4 \
    --to=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=chia7712@gmail.com \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=lkp@intel.com \
    --cc=qiang.zhang@linux.dev \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    --cc=yphbchou0911@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.