From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6E8C3BD63D for ; Mon, 30 Mar 2026 11:50:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774871412; cv=none; b=CbJ5zPVhR8nKLfUbehpWMyedg9sknVWm5OPhK9pwhSb/krwUMaUbwFRsXrOTssdKeQmRvFgYiajo7Qs3vIfxlp6+HeKPtRL2QPT0InoO5gUz1QMeqC9wNIZaqmovRLu02/D+lKk9OpHFRqYwtFpDAH46GcGJFZQ797aKssA0Kg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774871412; c=relaxed/simple; bh=V2jUBt0x6eiPoSYgMop0snQK/1CsSIDxQUvqVYqq+qc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WF4qn5mhO5/RdYcFUQnSuQI0SSskfpbz/tcHQeUYW8BWKc0Rh7dhgdov4eqS2FbWXr6fjyBSGQWlgf6kzE7UZ93jnP7yILHRUpYUoOpcbyB+3tKMlMxVFcYhwmcGmUAZ0q53ckO+smKCHVzY53wZRx/U3v/EuL66A54miuESPsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=koMcEPG+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="koMcEPG+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72E49C2BCB3; Mon, 30 Mar 2026 11:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774871412; bh=V2jUBt0x6eiPoSYgMop0snQK/1CsSIDxQUvqVYqq+qc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=koMcEPG+LrzWmf81N8C71H/CvTMu8QpOmMaJaiix8ZeB/I+UqO4+Cd5HhhHzmwB0+ O7NQALQgYQPHoKFNixt2d2TRx1jxhhfIyQ31OYSjofT3LNbOWlhRQBbz7SM1woGvWP N1emq4GiB6BVTzFKj/RWIdu+64LhMuGDCdai52+eWZGNwazoNocPoA3QD5etXZvvZP NpoztOvaYVW/0NpeQj1SQFTIeAaDGX9gMcxg0d1qjJMeVNhzBsGAOZ5vhxe19MCZ3g drnCo5q9M3NDHKVAP6r7ahxqtTkFii9jvxLcuW5EyVIAasgPo11s7uOaSWyTDDi7xq yOIiLp5MgC6qg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1w7B8E-0000000722S-0N2C; Mon, 30 Mar 2026 13:50:10 +0200 Date: Mon, 30 Mar 2026 13:50:10 +0200 From: Johan Hovold To: Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] greybus: es2: drop redundant device reference Message-ID: References: <20260311082226.14865-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260311082226.14865-1-johan@kernel.org> On Wed, Mar 11, 2026 at 09:22:26AM +0100, Johan Hovold wrote: > Driver core holds a reference to the USB interface and its parent USB > device while the interface is bound to a driver and there is no need to > take additional references unless the structures are needed after > disconnect. > > Drop the redundant device reference to reduce cargo culting, make it > easier to spot drivers where an extra reference is needed, and reduce > the risk of memory leaks when drivers fail to release it. > > Signed-off-by: Johan Hovold > --- > > This one needs one more spin... Sorry about the mess up. > Changes in v3: > - drop the leftover usb_dev_put() in early error paths > > Changes in v2: > - drop temporary udev variable as reported by the kernel test robot > (W=1 warning) Greg, can you pick this one up for 7.1? Johan