From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Kevin Hilman <khilman@baylibre.com>,
Arnd Bergmann <arnd@arndb.de>,
brgl@kernel.org, driver-core@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 2/3] driver core: make software nodes available earlier
Date: Mon, 30 Mar 2026 14:46:45 -0700 [thread overview]
Message-ID: <acruxMNdnUlyRHiy@google.com> (raw)
In-Reply-To: <acrcDTPpXZ_5A4D8@ashevche-desk.local>
On Mon, Mar 30, 2026 at 11:24:45PM +0300, Andy Shevchenko wrote:
> On Mon, Mar 30, 2026 at 02:40:47PM +0200, Bartosz Golaszewski wrote:
> > Software nodes are currently initialized in a function registered as
> > a postcore_initcall(). However, some devices may want to register
> > software nodes earlier than that (or also in a postcore_initcall() where
> > they're at the merci of the link order). Move the initialization to
> > driver_init() making swnode available much earlier as well as making
> > their initialization time deterministic.
>
> ...
>
> > -static void __exit software_node_exit(void)
> > -{
> > - ida_destroy(&swnode_root_ids);
> > - kset_unregister(swnode_kset);
> > }
> > -__exitcall(software_node_exit);
>
>
> Why? What's wrong with the __exitcall?
>
It's dead code. Always was, always will be.
Maybe split in a separate patch, but I sometimes feel the idea of "one
change" is taken to extreme and adds to both developer's and maintainers
burden by needing to keep track of extra patches.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-03-30 21:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 12:40 [PATCH v4 0/3] ARM: omap1: use real firmware node lookup for GPIOs on Nokia 770 Bartosz Golaszewski
2026-03-30 12:40 ` [PATCH v4 1/3] kernel: ksysfs: initialize kernel_kobj earlier Bartosz Golaszewski
2026-03-30 13:47 ` Danilo Krummrich
2026-03-30 14:19 ` Bartosz Golaszewski
2026-03-30 14:34 ` Danilo Krummrich
2026-03-30 12:40 ` [PATCH v4 2/3] driver core: make software nodes available earlier Bartosz Golaszewski
2026-03-30 20:24 ` Andy Shevchenko
2026-03-30 21:46 ` Dmitry Torokhov [this message]
2026-03-31 6:25 ` Andy Shevchenko
2026-03-31 6:52 ` Dmitry Torokhov
2026-03-31 8:55 ` Andy Shevchenko
2026-03-31 8:58 ` Bartosz Golaszewski
2026-03-31 10:45 ` Arnd Bergmann
2026-03-31 11:09 ` Andy Shevchenko
2026-03-31 14:28 ` Arnd Bergmann
2026-03-30 12:40 ` [PATCH v4 3/3] ARM: omap1: enable real software node lookup of GPIOs on Nokia 770 Bartosz Golaszewski
2026-03-30 13:37 ` [PATCH v4 0/3] ARM: omap1: use real firmware node lookup for " Danilo Krummrich
2026-03-30 13:52 ` Bartosz Golaszewski
2026-03-30 14:08 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acruxMNdnUlyRHiy@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jmkrzyszt@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.