All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, bestswngs@gmail.com
Subject: Re: [PATCH nf] netfilter: x_tables: restrict xt_check_match/xt_check_target extensions for NFPROTO_ARP
Date: Tue, 31 Mar 2026 17:07:52 +0200	[thread overview]
Message-ID: <acvjSICL-a6LJK74@strlen.de> (raw)
In-Reply-To: <20260331150146.958012-1-pablo@netfilter.org>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> +	/* NFPROTO_UNSPEC implies NF_INET_* hooks which do not overlap with
> +	 * NF_ARP_IN,OUT,FORWARD, allow explicit extensions with NFPROTO_ARP
> +	 * support.
> +	 */
> +	if (par->family == NFPROTO_ARP &&
> +	    par->match->family != NFPROTO_ARP) {
> +		pr_info_ratelimited("%s_tables: %s match: not valid for this family\n",
> +				    xt_prefix[par->family], par->match->name);
> +		return -EINVAL;
> +	}
>  	if (par->match->hooks && (par->hook_mask & ~par->match->hooks) != 0) {
>  		char used[64], allow[64];

Thanks Pablo, this looks fine.

      reply	other threads:[~2026-03-31 15:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 15:01 [PATCH nf] netfilter: x_tables: restrict xt_check_match/xt_check_target extensions for NFPROTO_ARP Pablo Neira Ayuso
2026-03-31 15:07 ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acvjSICL-a6LJK74@strlen.de \
    --to=fw@strlen.de \
    --cc=bestswngs@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.