All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Joy Zou <joy.zou@nxp.com>
Cc: Frank Li <Frank.Li@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	 Jacky Bai <ping.bai@nxp.com>, Ye Li <ye.li@nxp.com>,
	imx@lists.linux.dev,  linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] snvs_pwrkey - code improvements and add report event
Date: Tue, 31 Mar 2026 21:50:00 -0700	[thread overview]
Message-ID: <acyj0nmx9MRYGjM6@google.com> (raw)
In-Reply-To: <20260326-pwrkey-cleanup-v1-0-d85d7c0bf275@nxp.com>

On Thu, Mar 26, 2026 at 06:39:37PM +0800, Joy Zou wrote:
> This patch series improves the snvs_pwrkey driver with better code quality
> and add report press event.
> 
> The main improvements include:
> 1. Clean up the code by using local device pointers and dev_err_probe() for
> better readability and easier debugging.
> 
> 2. Fix potential event loss during system suspend by reporting key press events
> directly in the interrupt handler.
> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>

Please address comments form here:

https://sashiko.dev/#/patchset/20260326-pwrkey-cleanup-v1-0-d85d7c0bf275%40nxp.com

Majority of them seem valid.

Thanks.

-- 
Dmitry

      parent reply	other threads:[~2026-04-01  4:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 10:39 [PATCH 0/3] snvs_pwrkey - code improvements and add report event Joy Zou
2026-03-26 10:39 ` [PATCH 1/3] Input: snvs_pwrkey - make use of dev_err_probe() Joy Zou
2026-03-26 19:51   ` Frank Li
2026-03-26 10:39 ` [PATCH 2/3] Input: snvs_pwrkey - use local device pointer avoid reference platform_device pointer every time Joy Zou
2026-03-26 19:55   ` Frank Li
2026-03-26 10:39 ` [PATCH 3/3] Input: snvs_pwrkey - report press event in interrupt handler Joy Zou
2026-03-26 19:57   ` Frank Li
2026-03-31 10:46     ` Joy Zou
2026-03-31 14:11       ` Frank Li
2026-04-01  4:50 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acyj0nmx9MRYGjM6@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=Frank.Li@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=joy.zou@nxp.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.