All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] memcg: scale memcontrol03 checkpoint timeouts for slow kernels
Date: Wed, 1 Apr 2026 12:37:27 +0200	[thread overview]
Message-ID: <acz1ZwkNHRFjnJ1_@yuki.lan> (raw)
In-Reply-To: <20260330102909.863484-3-vasileios.almpanis@virtuozzo.com>

Hi!
> +#define CHECKPOINT_TIMEOUT_MS (tst_multiply_timeout(10) * 1000)

Wouldn't it make more sense to use the tst_multiply_timeout() directly
in the checkpoint library and hide that complexity from the tests?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-04-01 10:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 10:20 [LTP] [PATCH 0/2] configurable wake timeout and memcontrol03 fixes Vasileios Almpanis via ltp
2026-03-30 10:20 ` [LTP] [PATCH 1/2] lib/checkpoint: add configurable timeout for checkpoint wake Vasileios Almpanis via ltp
2026-04-02  9:57   ` [LTP] [PATCH v2 1/1] lib: scale checkpoint wait/wake timeouts with tst_multiply_timeout() Vasileios Almpanis via ltp
2026-04-02 12:52     ` Cyril Hrubis
2026-04-02 20:11       ` Petr Vorel
2026-04-08  8:44         ` Li Wang via ltp
2026-03-30 10:20 ` [LTP] [PATCH 2/2] memcg: scale memcontrol03 checkpoint timeouts for slow kernels Vasileios Almpanis via ltp
2026-04-01 10:37   ` Cyril Hrubis [this message]
2026-04-01 10:44     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acz1ZwkNHRFjnJ1_@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=vasileios.almpanis@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.