Re: [PATCH v2 52/67] ui/vnc: expose vnc_disconnect_start()

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Apr 10, 2026 at 11:19:14PM +0400, Marc-André Lureau wrote:
> This allows VncDisplay users to tear down all clients before freeing the
> VncDisplay for example.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  ui/vnc.h | 1 +
>  ui/vnc.c | 3 +--
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ui/vnc.h b/ui/vnc.h
> index de41517be48..794341265b3 100644
> --- a/ui/vnc.h
> +++ b/ui/vnc.h
> @@ -560,6 +560,7 @@ void vnc_display_free(VncDisplay *vd);
>   *****************************************************************************/
>  
>  /* Event loop functions */
> +void vnc_disconnect_start(VncState *vs);

AFAICT, nothing later in this series calls this, so this patch
looks redundant

>  gboolean vnc_client_io(QIOChannel *ioc,
>                         GIOCondition condition,
>                         void *opaque);
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 747b1c44e36..6fef80e98c4 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -617,7 +617,6 @@ bool vnc_display_reload_certs(const char *id, Error **errp)
>  */
>  
>  static int vnc_update_client(VncState *vs, int has_dirty);
> -static void vnc_disconnect_start(VncState *vs);
>  
>  static void vnc_colordepth(VncState *vs);
>  static void framebuffer_update_request(VncState *vs, int incremental,
> @@ -1296,7 +1295,7 @@ static void audio_del(VncState *vs)
>      }
>  }
>  
> -static void vnc_disconnect_start(VncState *vs)
> +void vnc_disconnect_start(VncState *vs)
>  {
>      if (vs->disconnecting) {
>          return;
> 
> -- 
> 2.53.0
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|