From: Dan Carpenter <error27@gmail.com>
To: Maxwell Doose <m32285159@gmail.com>
Cc: gregkh@linuxfoundation.org, tsbogend@alpha.franken.de,
len.bao@gmx.us, yoelvisoliveros@gmail.com,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2] staging: octeon: remove SPI, POW, PKO, and Helper typedef enums
Date: Wed, 15 Apr 2026 15:32:49 +0300 [thread overview]
Message-ID: <ad-FcZeXsFlSPXQj@stanley.mountain> (raw)
In-Reply-To: <20260415122939.77847-1-m32285159@gmail.com>
On Wed, Apr 15, 2026 at 07:29:39AM -0500, Maxwell Doose wrote:
> This patch removes custom typedef enums and replaces them with standard
> enums to address the "General code review and cleanup" task in TODO.
>
> The following enums are affected:
>
> - cvmx_spi_mode_t (now enum cvmx_spi_mode)
> - cvmx_helper_interface_mode_t (now enum cvmx_helper_interface_mode_e)
Presumably the "_e" stands for enum? Ugh. No. Don't do that.
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-15 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 12:29 [PATCH v2] staging: octeon: remove SPI, POW, PKO, and Helper typedef enums Maxwell Doose
2026-04-15 12:32 ` Dan Carpenter [this message]
2026-04-15 13:31 ` Max
2026-04-15 13:50 ` Dan Carpenter
2026-04-15 14:54 ` Max
2026-04-17 21:16 ` kernel test robot
2026-04-18 14:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad-FcZeXsFlSPXQj@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.bao@gmx.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=m32285159@gmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=yoelvisoliveros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.