Re: [PATCH] ASoC: Intel: hdac_hdmi: add Icelake support

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

>>> Also, it'd be helpful if you fix the same for the legacy HD-audio HDMI
>>> codec driver.
>> Our intention was to revisit differences between legacy and non-legacy
>> in a separate patch if that's all right with you. We've identified
>> missing IDs and other things that should be fixed separately.
> Sure, I don't mean to fix both in a single patch, but just to remind
> you guys not to forget about that code path.

Yes, this is very much on our radar. I don't like the current approach 
where patch_hdmi.c and hdac_hdmi.c have duplicated/different definitions 
for the same things or capabilities that can't be traced back to 
hardware documentation or known issues. the main issue I am facing with 
the legacy path is ironically validation. Our team necessarily have 
access to all commercially-available platforms listed in those files or 
when we do it's not necessarily easy to work with the latest kernel or 
handle BIOS issues - we'll do what we can though.

And btw the big topic is still how we provide distributions the means to 
handle a 'graceful' fallback from DSP-enabled solutions (SST or SOF) to 
legacy HDAudio, it's already popped up for cases where we have HDaudio 
solutions with DMICs.

-Pierre