Re: [PATCH v1 2/7] mpi3mr: Rename log data save helper to reflect threaded/BH context

[Damien Le Moal <dlemoal@kernel.org>]

On 1/12/26 09:10, Ranjan Kumar wrote:
> Log data events can be processed from BH and threaded contexts.
> Rename the save helper to document its intended usage and improve
> readability of the event handling flow.
> 
> Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com>
> ---
>  drivers/scsi/mpi3mr/mpi3mr.h     | 2 +-
>  drivers/scsi/mpi3mr/mpi3mr_app.c | 4 ++--
>  drivers/scsi/mpi3mr/mpi3mr_os.c  | 8 +++++++-
>  3 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/mpi3mr/mpi3mr.h b/drivers/scsi/mpi3mr/mpi3mr.h
> index 31d68c151b20..611a51a353c9 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr.h
> +++ b/drivers/scsi/mpi3mr/mpi3mr.h
> @@ -1508,7 +1508,7 @@ void mpi3mr_pel_get_seqnum_complete(struct mpi3mr_ioc *mrioc,
>  	struct mpi3mr_drv_cmd *drv_cmd);
>  int mpi3mr_pel_get_seqnum_post(struct mpi3mr_ioc *mrioc,
>  	struct mpi3mr_drv_cmd *drv_cmd);
> -void mpi3mr_app_save_logdata(struct mpi3mr_ioc *mrioc, char *event_data,
> +void mpi3mr_app_save_logdata_th(struct mpi3mr_ioc *mrioc, char *event_data,
>  	u16 event_data_size);
>  struct mpi3mr_enclosure_node *mpi3mr_enclosure_find_by_handle(
>  	struct mpi3mr_ioc *mrioc, u16 handle);
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_app.c b/drivers/scsi/mpi3mr/mpi3mr_app.c
> index 0e5478d62580..37cca0573ddc 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_app.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_app.c
> @@ -2920,7 +2920,7 @@ static long mpi3mr_bsg_process_mpt_cmds(struct bsg_job *job)
>  }
>  
>  /**
> - * mpi3mr_app_save_logdata - Save Log Data events
> + * mpi3mr_app_save_logdata_th - Save Log Data events
>   * @mrioc: Adapter instance reference
>   * @event_data: event data associated with log data event
>   * @event_data_size: event data size to copy
> @@ -2932,7 +2932,7 @@ static long mpi3mr_bsg_process_mpt_cmds(struct bsg_job *job)
>   *
>   * Return:Nothing
>   */
> -void mpi3mr_app_save_logdata(struct mpi3mr_ioc *mrioc, char *event_data,
> +void mpi3mr_app_save_logdata_th(struct mpi3mr_ioc *mrioc, char *event_data,
>  	u16 event_data_size)
>  {
>  	u32 index = mrioc->logdata_buf_idx, sz;
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
> index d4ca878d0886..4dbf2f337212 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
> @@ -1962,7 +1962,7 @@ static void mpi3mr_pcietopochg_evt_bh(struct mpi3mr_ioc *mrioc,
>  static void mpi3mr_logdata_evt_bh(struct mpi3mr_ioc *mrioc,
>  	struct mpi3mr_fwevt *fwevt)
>  {
> -	mpi3mr_app_save_logdata(mrioc, fwevt->event_data,
> +	mpi3mr_app_save_logdata_th(mrioc, fwevt->event_data,
>  	    fwevt->event_data_size);
>  }
>  
> @@ -3058,6 +3058,12 @@ void mpi3mr_os_handle_events(struct mpi3mr_ioc *mrioc,
>  	}
>  	case MPI3_EVENT_DEVICE_INFO_CHANGED:
>  	case MPI3_EVENT_LOG_DATA:
> +	{

The curly brackets are not necessary.

> +		sz = event_reply->event_data_length * 4;
> +		mpi3mr_app_save_logdata_th(mrioc,
> +		    (char *)event_reply->event_data, sz);

Do you really need the cast here ?

> +		break;
> +	}
>  	case MPI3_EVENT_ENCL_DEVICE_STATUS_CHANGE:
>  	case MPI3_EVENT_ENCL_DEVICE_ADDED:
>  	{


-- 
Damien Le Moal
Western Digital Research