From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: George Moussalem <george.moussalem@outlook.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Devi Priya <quic_devipriy@quicinc.com>
Subject: Re: [PATCH v21 2/6] pwm: driver for qualcomm ipq6018 pwm block
Date: Mon, 13 Apr 2026 22:27:33 +0200 [thread overview]
Message-ID: <ad1RFmg0AEb7hudQ@monoceros> (raw)
In-Reply-To: <DS7PR19MB888389B41E784995F064EE0B9D242@DS7PR19MB8883.namprd19.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]
Hello George,
On Mon, Apr 13, 2026 at 11:17:18PM +0400, George Moussalem wrote:
> On 4/13/2026 1:35 PM, Uwe Kleine-König wrote:
> > On Mon, Apr 06, 2026 at 10:24:39PM +0200, George Moussalem via B4 Relay wrote:
> >> From: Devi Priya <quic_devipriy@quicinc.com>
> >>
> >> Driver for the PWM block in Qualcomm IPQ6018 line of SoCs. Based on
> >> driver from downstream Codeaurora kernel tree. Removed support for older
> >> (V1) variants because I have no access to that hardware.
> >>
> >> Tested on IPQ5018 and IPQ6010 based hardware.
> >>
> >> Co-developed-by: Baruch Siach <baruch.siach@siklu.com>
> >> Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
> >> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
> >> Reviewed-by: Bjorn Andersson <andersson@kernel.org>
> >> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> >
> > I have a few remaining nitpicks. If you're ok I'll squash the following
> > diff into this patch and apply it:
>
> Just applied it to my own branch, all okay from my side. Thanks for your
> guidance and support!
I did that and added a ; to make the compiler happy. It is now contained
at
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-nexxt
as 7.2-rc1 material. I'll push it into next after the merge window
closes in ~ two weeks.
Best regards and thanks for work
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-13 20:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 20:24 [PATCH v21 0/6] Add PWM support for IPQ chipsets George Moussalem
2026-04-06 20:24 ` George Moussalem via B4 Relay
2026-04-06 20:24 ` [PATCH v21 1/6] dt-bindings: pwm: add IPQ6018 binding George Moussalem
2026-04-06 20:24 ` George Moussalem via B4 Relay
2026-04-06 20:24 ` [PATCH v21 2/6] pwm: driver for qualcomm ipq6018 pwm block George Moussalem
2026-04-06 20:24 ` George Moussalem via B4 Relay
2026-04-13 9:35 ` Uwe Kleine-König
2026-04-13 19:17 ` George Moussalem
2026-04-13 20:27 ` Uwe Kleine-König [this message]
2026-04-06 20:24 ` [PATCH v21 3/6] arm64: dts: qcom: ipq6018: add pwm node George Moussalem
2026-04-06 20:24 ` George Moussalem via B4 Relay
2026-04-06 20:24 ` [PATCH v21 4/6] arm64: dts: qcom: ipq5018: " George Moussalem
2026-04-06 20:24 ` George Moussalem via B4 Relay
2026-04-06 20:24 ` [PATCH v21 5/6] arm64: dts: qcom: ipq5332: " George Moussalem
2026-04-06 20:24 ` George Moussalem via B4 Relay
2026-04-06 20:24 ` [PATCH v21 6/6] arm64: dts: qcom: ipq9574: " George Moussalem
2026-04-06 20:24 ` George Moussalem via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad1RFmg0AEb7hudQ@monoceros \
--to=ukleinek@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.moussalem@outlook.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=quic_devipriy@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.