From: David Hildenbrand <david@redhat.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Oscar Salvador <osalvador@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init()
Date: Thu, 25 Jul 2019 11:23:35 +0200 [thread overview]
Message-ID: <ad2d85a0-e7a5-1d76-3984-fa4972853496@redhat.com> (raw)
In-Reply-To: <CAJZ5v0iBntT1c7gKkXG-RJpabZne2n-Afq40GKeA6-tUViVZuQ@mail.gmail.com>
On 25.07.19 11:22, Rafael J. Wysocki wrote:
> On Thu, Jul 25, 2019 at 11:18 AM Oscar Salvador <osalvador@suse.de> wrote:
>>
>> On Wed, Jul 24, 2019 at 04:30:17PM +0200, David Hildenbrand wrote:
>>> We end up calling __add_memory() without the device hotplug lock held.
>>> (I used a local patch to assert in __add_memory() that the
>>> device_hotplug_lock is held - I might upstream that as well soon)
>>>
>>> [ 26.771684] create_memory_block_devices+0xa4/0x140
>>> [ 26.772952] add_memory_resource+0xde/0x200
>>> [ 26.773987] __add_memory+0x6e/0xa0
>>> [ 26.775161] acpi_memory_device_add+0x149/0x2b0
>>> [ 26.776263] acpi_bus_attach+0xf1/0x1f0
>>> [ 26.777247] acpi_bus_attach+0x66/0x1f0
>>> [ 26.778268] acpi_bus_attach+0x66/0x1f0
>>> [ 26.779073] acpi_bus_attach+0x66/0x1f0
>>> [ 26.780143] acpi_bus_scan+0x3e/0x90
>>> [ 26.780844] acpi_scan_init+0x109/0x257
>>> [ 26.781638] acpi_init+0x2ab/0x30d
>>> [ 26.782248] do_one_initcall+0x58/0x2cf
>>> [ 26.783181] kernel_init_freeable+0x1bd/0x247
>>> [ 26.784345] kernel_init+0x5/0xf1
>>> [ 26.785314] ret_from_fork+0x3a/0x50
>>>
>>> So perform the locking just like in acpi_device_hotplug().
>>>
>>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>>> Cc: Len Brown <lenb@kernel.org
>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>> Cc: Oscar Salvador <osalvador@suse.de>
>>> Cc: Michal Hocko <mhocko@suse.com>
>>> Signed-off-by: David Hildenbrand <david@redhat.com>
>>
>> Given that that call comes from a __init function, so while booting, I wonder
>> how bad it is.
>
> Yes, it probably does not matter.
It can at least confuse lockdep, but I agree that this is not stable
material.
>
>> Anyway, let us be consistent:
>
> Right.
>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-07-25 9:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 14:30 [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init() David Hildenbrand
2019-07-25 9:11 ` Rafael J. Wysocki
2019-07-25 9:18 ` Oscar Salvador
2019-07-25 9:22 ` Rafael J. Wysocki
2019-07-25 9:23 ` David Hildenbrand [this message]
2019-07-25 12:56 ` Michal Hocko
2019-07-25 13:05 ` David Hildenbrand
2019-07-25 13:57 ` Michal Hocko
2019-07-25 14:35 ` David Hildenbrand
2019-07-25 19:19 ` Michal Hocko
2019-07-25 20:49 ` David Hildenbrand
2019-07-25 21:23 ` Rafael J. Wysocki
2019-07-26 7:20 ` David Hildenbrand
2019-07-26 7:57 ` Michal Hocko
2019-07-26 8:05 ` David Hildenbrand
2019-07-26 8:31 ` Michal Hocko
2019-07-26 8:36 ` David Hildenbrand
2019-07-26 8:44 ` Michal Hocko
2019-07-26 8:57 ` David Hildenbrand
2019-07-26 10:31 ` Michal Hocko
2019-07-26 10:37 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad2d85a0-e7a5-1d76-3984-fa4972853496@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.