From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CE6DCC6B2F for ; Thu, 15 Oct 2026 07:41:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xHG5Y-0005yQ-3z; Thu, 15 Oct 2026 03:41:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHG5V-0005wj-UU for qemu-devel@nongnu.org; Thu, 15 Oct 2026 03:41:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHG5U-0003UE-3R for qemu-devel@nongnu.org; Thu, 15 Oct 2026 03:41:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792050075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tqYvKyXYpVWaxLh4p6xaXJDnBFaKaNdOcSB4od9Stjk=; b=YCRg9nQu9Bj2C1EojhnlvYN0nbC2e8RN0qLGBLWP9BkKLVKevvSuYKfwXBrHOWVsnmwhYr NjcFVjYTbmz5Qt2DcVXShhBHY/X9eUuFuD3nHzoqwkNkidIrGnmNeW+anFHAxqSR5Z76ik ln7o9WxK8cQ2riBSpEB+FfGT2SRYwfM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-UjTauZPhN5WRNynu88EVFQ-1; Thu, 15 Oct 2026 07:41:13 +0000 X-MC-Unique: UjTauZPhN5WRNynu88EVFQ-1 X-Mimecast-MFC-AGG-ID: UjTauZPhN5WRNynu88EVFQ_1792050072 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48c427421f6so977218f8f.2 for ; Thu, 15 Oct 2026 00:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1792050072; x=1792654872; darn=nongnu.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=tqYvKyXYpVWaxLh4p6xaXJDnBFaKaNdOcSB4od9Stjk=; b=UqBZhGXzMT21w5wHSDdznfvRkYHgOO8dxZNbxP/11crKWK+LIF+Hahgno8Wt37xrfP Ll/DO819CACtgGyzXYZ63Qq+JaVtEfU2AgXFPrt/kEWPWItz+OQcQO0WFFDrUxNdXjP4 qy9Fq4phE5Q81dGGjjinZZ6hLQbNdAKwskwp9kClOvRCMoX6uAo+D+fUQokb8GUYFIs7 N8mYCvzavm5KddzfI+7sEHz/s688eHQeAuYMtgemQrWp2WXXgemXvTDvl7PeKcjkUkmH WuiXtYLBHcsCbZNcDzDsQPUIbofKOabbx2eHUpWWGp7EBoEAy1dotwbjcnFDHtJ9Wlj9 Xo9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792050072; x=1792654872; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=tqYvKyXYpVWaxLh4p6xaXJDnBFaKaNdOcSB4od9Stjk=; b=U5l0ghKWWfTqaz1UINFtjb2N8QOFb1Rj396lAxbvsUQXgx7RfQkVa3Bh9ZKeGohmgF AcCDmKVE/SCwZymGD4jjNinvFtpHZZKKdbGOpidkaHxTrN+lQemWs2Zx/sz0v3gOa5x4 8fCKlaRvt8bsiVXsn2iy+fyFtPbHEa9VG9G0jQJuaRLjS+3lptREfaKltY2uw5Nh4rn4 MrK8cFBDbrzeiEsLJMSyo4Px2UAFyiWFrsaXSwKMqb6at6q+Ybes1slqqsAjYDLRLu3f nSQOzk/85AbCnTLX9/9Im0t1MUzTGKxBnR9HWsfikJy8AXAJBKA3AApPYXoHqKj28RHr 2XhQ== X-Forwarded-Encrypted: i=1; AKwUvBxUmhuhaqKUgDz6FhA99bsMTY4txNmuM5hcYlrQUceGn5K4Sr8Wi5DEp1i3ZJQLbg2l33sP6MQB3FAF@nongnu.org X-Gm-Message-State: AFq9FYL9O4AAGhxqfc75Xxl0xw94GC3bPS5qFiWndJcZe3BwU9E9Cjdw hAZ+3zbdM6ldqiDkzT0W/YEstvVOOnsbzpqfRj0ibP8EgOj9dBRKLT6lWMfSVvfO9txxO0Y6eWG zyp34ISz5ucoDVF3NmVyZX3bCF+BUk3vRXNOYolrO8zuTZIaAxlah9POS X-Gm-Gg: AYBFou33mfKOKfWyp0LwwluNHnnKUo3BWjMbqFMCZ4vniKhjMS6XhdBsARlQWbFSF7h t2OZoW2kVcW+nnQoWI+RBVYYV0QpQX8Id2OcAQD+Xc6oS+fG8hkPdFdQmHpLOdH5oc74OkDBii0 sKDhrTwTQbbbhsg7rdg78ORC2rKcfQNvEcHELjzlftzipGpDjgXWtIo50c8zVegifWum2caV2Sv ebXi4BLVEoKFkCZo4kIEVx83Vlwm6Olcqa2UuzuLvDHXqYpUOny1xzOp7ChGLoT/FNi9z4PV8zu dxJOjt+isozEaSq/6FUkVgTHunL4AR2rofZqvlzzicGdsG+fkLlp6nf8FlDfBAQCyfYUIjrIhsa bYR2nY+8VJtk45X7m8k3K6evNmOT/d+Eq+haQWOu5 X-Received: by 2002:a05:600c:8208:b0:4a0:1b14:d00c with SMTP id 5b1f17b1804b1-4a18e446f55mr364634535e9.3.1792050072389; Thu, 15 Oct 2026 00:41:12 -0700 (PDT) X-Received: by 2002:a05:600c:8208:b0:4a0:1b14:d00c with SMTP id 5b1f17b1804b1-4a18e446f55mr364634125e9.3.1792050071930; Thu, 15 Oct 2026 00:41:11 -0700 (PDT) Received: from ?IPV6:2a01:e0a:1292:d530:578a:3c67:6721:1232? ([2a01:e0a:1292:d530:578a:3c67:6721:1232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1bd64b5e7sm51416075e9.2.2026.10.15.00.41.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2026 00:41:11 -0700 (PDT) Message-ID: Date: Thu, 15 Oct 2026 09:41:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/4] vfio: add setup_sparse_mmaps hook to VFIODeviceIOOps To: Naman Gulati , qemu-devel@nongnu.org Cc: John Levon , Thanos Makatos , Alex Williamson , Pierrick Bouvier , Matt Evans References: <20261014211041.1087331-1-namangulati@google.com> <20261014211041.1087331-4-namangulati@google.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20261014211041.1087331-4-namangulati@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/14/26 23:10, Naman Gulati wrote: > Add a setup_sparse_mmaps callback to VFIODeviceIOOps so transport > backends (such as vfio-user) can parse custom sparse mmap capabilities, > falling back to vfio_default_setup_sparse_mmaps() to process shared > VFIO mmap capabilities. > > Reviewed-by: Thanos Makatos > Signed-off-by: Naman Gulati > --- > hw/vfio/vfio-region.h | 5 +++++ > include/hw/vfio/vfio-device.h | 16 ++++++++++++++++ > hw/vfio/device.c | 1 + > hw/vfio/region.c | 19 ++++++++++++++++--- > 4 files changed, 38 insertions(+), 3 deletions(-) > > diff --git a/hw/vfio/vfio-region.h b/hw/vfio/vfio-region.h > index 9f6a5cf7d5..a0c9533f9f 100644 > --- a/hw/vfio/vfio-region.h > +++ b/hw/vfio/vfio-region.h > @@ -46,4 +46,9 @@ void vfio_region_mmaps_set_enabled(VFIORegion *region, bool enabled); > void vfio_region_exit(VFIORegion *region); > void vfio_region_finalize(VFIORegion *region); > > +struct vfio_region_info; > +int vfio_default_setup_sparse_mmaps(VFIORegion *region, > + struct vfio_region_info *info, > + Error **errp); If you resend, I'd prefer this routine to be named : vfio_region_setup_sparse_mmaps() Thanks, C. > + > #endif /* HW_VFIO_REGION_H */ > diff --git a/include/hw/vfio/vfio-device.h b/include/hw/vfio/vfio-device.h > index 8472420d3f..3136e152f2 100644 > --- a/include/hw/vfio/vfio-device.h > +++ b/include/hw/vfio/vfio-device.h > @@ -43,6 +43,7 @@ enum { > > typedef struct VFIODeviceOps VFIODeviceOps; > typedef struct VFIODeviceIOOps VFIODeviceIOOps; > +typedef struct VFIORegion VFIORegion; > typedef struct VFIOMigration VFIOMigration; > > typedef struct IOMMUFDBackend IOMMUFDBackend; > @@ -218,6 +219,21 @@ struct VFIODeviceIOOps { > int (*get_region_info)(VFIODevice *vdev, > struct vfio_region_info *info, int *fd); > > + /** > + * @setup_sparse_mmaps > + * > + * Parse sparse mmap capabilities for a region and initialize region->mmaps. > + * > + * @region: #VFIORegion to set up > + * @info: region info struct containing capabilities > + * @errp: pointer to Error*, to store an error if it happens > + * > + * Returns 0 on success, -ENODEV if not sparse, or negative error code. > + */ > + int (*setup_sparse_mmaps)(VFIORegion *region, > + struct vfio_region_info *info, > + Error **errp); > + > /** > * @get_irq_info > * > diff --git a/hw/vfio/device.c b/hw/vfio/device.c > index 4f11959633..94d6e7ce09 100644 > --- a/hw/vfio/device.c > +++ b/hw/vfio/device.c > @@ -662,6 +662,7 @@ static VFIODeviceIOOps vfio_device_io_ops_ioctl = { > > .device_feature = vfio_device_io_device_feature, > .get_region_info = vfio_device_io_get_region_info, > + .setup_sparse_mmaps = vfio_default_setup_sparse_mmaps, > .get_irq_info = vfio_device_io_get_irq_info, > .set_irqs = vfio_device_io_set_irqs, > .region_read = vfio_device_io_region_read, > diff --git a/hw/vfio/region.c b/hw/vfio/region.c > index 16efed2fce..94cfb708bf 100644 > --- a/hw/vfio/region.c > +++ b/hw/vfio/region.c > @@ -162,9 +162,9 @@ static int vfio_mmap_compare_offset(const void *a, const void *b) > return 0; > } > > -static int vfio_setup_region_sparse_mmaps(VFIORegion *region, > - struct vfio_region_info *info, > - Error **errp) > +int vfio_default_setup_sparse_mmaps(VFIORegion *region, > + struct vfio_region_info *info, > + Error **errp) > { > struct vfio_info_cap_header *hdr; > struct vfio_region_info_cap_sparse_mmap *sparse; > @@ -198,6 +198,19 @@ static int vfio_setup_region_sparse_mmaps(VFIORegion *region, > > region->nr_mmaps = j; > region->mmaps = g_realloc(region->mmaps, j * sizeof(VFIOMmap)); > + return 0; > +} > + > +static int vfio_setup_region_sparse_mmaps(VFIORegion *region, > + struct vfio_region_info *info, > + Error **errp) > +{ > + int ret, i; > + > + ret = region->vbasedev->io_ops->setup_sparse_mmaps(region, info, errp); > + if (ret) { > + return ret; > + } > > /* > * Sort sparse mmaps by offset to ensure proper handling of gaps