All of lore.kernel.org
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Masakazu Asama <masakazu.asama@gmail.com>
Cc: <intel-wired-lan@osuosl.org>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@linux.dev>
Subject: Re: [Intel-wired-lan] The ice driver may rarely return incorrect statistics counter values
Date: Fri, 4 Jul 2025 13:25:21 +0200	[thread overview]
Message-ID: <ad3287ea-0bea-40e2-9d64-08d159e14026@intel.com> (raw)
In-Reply-To: <CAP8M2pHAv-kyNvvQ9L0oqRjThvdZT0ttYLAYVYV33MR3P_w+TQ@mail.gmail.com>

On 7/2/25 10:01, Masakazu Asama wrote:
>  > The first step is to check if the linked patch fixes the issue at hand,
>  > could you please give it a try?
> 
> Sorry for the long delay.
> It took some time to complete the verification, as the environment I 
> used for testing is not something I can access freely. I apologize for 
> the inconvenience.
> 
> I have confirmed that applying the patch 1a0f25a52e08 to the Ubuntu 
> 22.04 kernel (5.15) resolves the issue.
> I’ve attached graphs showing the transmit/receive statistics before and 
> after applying the patch.
> The data before May 30th is from before the patch was applied, and the 
> data after May 30th is from after the patch.

thank you! it's great that this resolves the issue

> 
> However, since kernel 5.15 still uses struct ice_ring instead of struct 
> ice_tx_ring, I was not able to apply the patch as-is.
> I had to make two small modifications to replace struct ice_tx_ring with 
> struct ice_ring.

for me it was just one place to change (but there was also conflict in
need of manual resolution, so that makes it "two small modifications")

> 
> As shown above, the patch 1a0f25a52e08 appears to be effective on 5.15 
> as well, so I would greatly appreciate it if you could consider 
> backporting it.

I will send this as a patch to stable kernel 5.15, CC'ing you;
I think that Canonical will pick it up that way too



      reply	other threads:[~2025-07-04 11:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21  3:12 [Intel-wired-lan] The ice driver may rarely return incorrect statistics counter values Masakazu Asama
2025-02-24 11:21 ` Przemek Kitszel
2025-07-02  8:01   ` Masakazu Asama
2025-07-04 11:25     ` Przemek Kitszel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad3287ea-0bea-40e2-9d64-08d159e14026@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    --cc=jesse.brandeburg@linux.dev \
    --cc=masakazu.asama@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.