From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F12FED7B82 for ; Tue, 14 Apr 2026 08:16:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCYuu-00045t-CU; Tue, 14 Apr 2026 04:14:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYu7-0003mJ-PY for qemu-devel@nongnu.org; Tue, 14 Apr 2026 04:13:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCYu5-0008Fw-3H for qemu-devel@nongnu.org; Tue, 14 Apr 2026 04:13:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776154426; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=CnPCsOuEwZhwJzSLwvDfGSm8D4tXLMEr74zD7KNkV7o=; b=XGtbqbbF9sgCYXg7ZRuCbp4FlaA/Wu/fnFF7T6fcc8XesoxFALO19kDJyUdmkFKU5pTU4q JnAJCvs5yvqBfQbXYnNPz5qD1P3Mi9yXRBTzCWLqcI/t04DIOs6DHZYUDVDnLxB9hbDoxy t0DHBP+wXQDFUY8O/NINOqxcjDUaryM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-nJEKJD2SP1qdsBWRt499Bw-1; Tue, 14 Apr 2026 04:13:43 -0400 X-MC-Unique: nJEKJD2SP1qdsBWRt499Bw-1 X-Mimecast-MFC-AGG-ID: nJEKJD2SP1qdsBWRt499Bw_1776154422 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1CFC71956080; Tue, 14 Apr 2026 08:13:42 +0000 (UTC) Received: from redhat.com (headnet01.pony-001.prod.iad2.dc.redhat.com [10.2.32.101]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2F641195608E; Tue, 14 Apr 2026 08:13:39 +0000 (UTC) Date: Tue, 14 Apr 2026 09:13:37 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Warner Losh Cc: qemu-devel@nongnu.org, Kyle Evans , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 3/5] bsd-user: Conditionally use old system calls Message-ID: References: <20260413-syscall-nr-v1-0-f70408d042ea@bsdimp.com> <20260413-syscall-nr-v1-3-f70408d042ea@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260413-syscall-nr-v1-3-f70408d042ea@bsdimp.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Apr 13, 2026 at 09:31:45AM -0600, Warner Losh wrote: > sbrk and sstk have been deprecated in FreeBSD for a while now, only > support them if the version of FreeBSD we're compiling on does. They've > returned not supported for a while anyway, so no net change. What versions of FreeBSD still have these syscalls ? Per out policy we only aim to support the 2 most recent major versions of distros: https://www.qemu.org/docs/master/about/build-platforms.html So for FreeBSD that means 14.x and 15.x series are all that you need to retain code support for. Any code for older versions can be entirely dropped at any convenient time. > > Signed-off-by: Warner Losh > --- > bsd-user/bsd-mem.h | 2 ++ > bsd-user/freebsd/os-syscall.c | 4 ++++ > bsd-user/freebsd/strace.list | 4 ++++ > 3 files changed, 10 insertions(+) > > diff --git a/bsd-user/bsd-mem.h b/bsd-user/bsd-mem.h > index a118e57260..a20b703053 100644 > --- a/bsd-user/bsd-mem.h > +++ b/bsd-user/bsd-mem.h > @@ -440,6 +440,7 @@ static inline abi_long do_bsd_vadvise(void) > return -TARGET_EINVAL; > } > > +#ifdef TARGET_FREEBSD_NR_sbrk > static inline abi_long do_bsd_sbrk(void) > { > /* see sys_sbrk() in vm_mmap.c */ > @@ -451,5 +452,6 @@ static inline abi_long do_bsd_sstk(void) > /* see sys_sstk() in vm_mmap.c */ > return -TARGET_EOPNOTSUPP; > } > +#endif > > #endif /* BSD_USER_BSD_MEM_H */ > diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c > index 85e5db19a3..ff6cbfc481 100644 > --- a/bsd-user/freebsd/os-syscall.c > +++ b/bsd-user/freebsd/os-syscall.c > @@ -918,13 +918,17 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1, > ret = do_bsd_vadvise(); > break; > > +#ifdef TARGET_FREEBSD_NR_sbrk > case TARGET_FREEBSD_NR_sbrk: > ret = do_bsd_sbrk(); > break; > +#endif > > +#ifdef TARGET_FREEBSD_NR_sstk > case TARGET_FREEBSD_NR_sstk: > ret = do_bsd_sstk(); > break; > +#endif > > /* > * Misc > diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list > index 275d2dbe27..d7f61f480e 100644 > --- a/bsd-user/freebsd/strace.list > +++ b/bsd-user/freebsd/strace.list > @@ -194,7 +194,9 @@ > { TARGET_FREEBSD_NR_rfork, "rfork", NULL, NULL, NULL }, > { TARGET_FREEBSD_NR_rmdir, "rmdir", NULL, NULL, NULL }, > { TARGET_FREEBSD_NR_rtprio_thread, "rtprio_thread", "%s(%d, %d, %p)", NULL, NULL }, > +#ifdef TARGET_FREEBSD_NR_sbrk > { TARGET_FREEBSD_NR_sbrk, "sbrk", NULL, NULL, NULL }, > +#endif > { TARGET_FREEBSD_NR_sched_get_priority_max, "sched_get_priority_max", NULL, NULL, NULL }, > { TARGET_FREEBSD_NR_sched_get_priority_min, "sched_get_priority_min", NULL, NULL, NULL }, > { TARGET_FREEBSD_NR_sched_yield, "sched_yield", NULL, NULL, NULL }, > @@ -234,7 +236,9 @@ > { TARGET_FREEBSD_NR_sigsuspend, "sigsuspend", NULL, NULL, NULL }, > { TARGET_FREEBSD_NR_socket, "socket", "%s(%d,%d,%d)", NULL, NULL }, > { TARGET_FREEBSD_NR_socketpair, "socketpair", NULL, NULL, NULL }, > +#ifdef TARGET_FREEBSD_NR_sstk > { TARGET_FREEBSD_NR_sstk, "sstk", NULL, NULL, NULL }, > +#endif > { TARGET_FREEBSD_NR_freebsd11_stat, "freebsd11_stat", "%s(\"%s\",%p)", NULL, NULL }, > { TARGET_FREEBSD_NR_freebsd11_statfs, "freebsd11_statfs", "%s(\"%s\",%p)", NULL, NULL }, > { TARGET_FREEBSD_NR_symlink, "symlink", "%s(\"%s\",\"%s\")", NULL, NULL }, > > -- > 2.52.0 > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|