From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xu, Rosen" <rosen.xu@intel.com>,
"Huang, Wei" <wei.huang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] raw/ifpga: fix ifpga device name format
Date: Sun, 25 Apr 2021 02:07:32 +0000 [thread overview]
Message-ID: <ad4eed951aba4c09ae3824bde0a7eaf3@intel.com> (raw)
In-Reply-To: <BYAPR11MB29014B78B5C4CFC109414BF489469@BYAPR11MB2901.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Xu, Rosen <rosen.xu@intel.com>
> Sent: Thursday, April 22, 2021 7:13 PM
> To: Huang, Wei <wei.huang@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Subject: RE: [PATCH v1] raw/ifpga: fix ifpga device name format
>
> Hi,
>
> > -----Original Message-----
> > From: Huang, Wei <wei.huang@intel.com>
> > Sent: Thursday, April 22, 2021 16:27
> > To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>
> > Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Yigit,
> > Ferruh <ferruh.yigit@intel.com>; Huang, Wei <wei.huang@intel.com>
> > Subject: [PATCH v1] raw/ifpga: fix ifpga device name format
> >
> > The device name format used in ifpga_rawdev_create() was changed to
> > "IFPGA:%02x:%02x.%x", but the format used in ifpga_rawdev_destroy()
> > was left as "IFPGA:%x:%02x.%x", it should be changed synchronously.
> >
> > Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Huang <wei.huang@intel.com>
> > ---
> > drivers/raw/ifpga/ifpga_rawdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c
> > b/drivers/raw/ifpga/ifpga_rawdev.c
> > index d9a46ef915..f591a87b49 100644
> > --- a/drivers/raw/ifpga/ifpga_rawdev.c
> > +++ b/drivers/raw/ifpga/ifpga_rawdev.c
> > @@ -1551,7 +1551,7 @@ ifpga_rawdev_destroy(struct rte_pci_device
> > *pci_dev)
> > }
> >
> > memset(name, 0, sizeof(name));
> > -snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%x:%02x.%x",
> > +snprintf(name, RTE_RAWDEV_NAME_MAX_LEN,
> > "IFPGA:%02x:%02x.%x",
> > pci_dev->addr.bus, pci_dev->addr.devid, pci_dev-
> > >addr.function);
> >
> > IFPGA_RAWDEV_PMD_INFO("Closing %s on NUMA node %d",
> > --
> > 2.29.2
>
> Acked-by: Rosen Xu <rosen.xu@intel.com>
Applied to dpdk-next-net-intel
Thanks
Qi
next prev parent reply other threads:[~2021-04-25 2:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 8:27 [dpdk-dev] [PATCH v1] raw/ifpga: fix ifpga device name format Wei Huang
2021-04-22 11:13 ` Xu, Rosen
2021-04-25 2:07 ` Zhang, Qi Z [this message]
2021-04-28 9:26 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad4eed951aba4c09ae3824bde0a7eaf3@intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
--cc=wei.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.