Re: [PATCH v2 6/7] tests: Add qtests for FlexCAN

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Apr 14, 2026 at 12:11:58PM +0000, Bernhard Beschow wrote:
> 
> 
> Am 13. April 2026 13:23:16 UTC schrieb "Daniel P. Berrangé" <berrange@redhat.com>:
> >On Mon, Apr 13, 2026 at 01:16:20PM +0000, Bernhard Beschow wrote:
> >> 
> >> 
> >> Am 19. März 2026 19:13:13 UTC schrieb "Matyáš Bobek" <matyas.bobek@gmail.com>:
> >> >The tests do not test all of the FlexCAN emulator functionality.
> >> >
> >> >Signed-off-by: Matyáš Bobek <matyas.bobek@gmail.com>
> >> >---
> >> > MAINTAINERS                |   1 +
> >> > tests/qtest/flexcan-test.c | 424 +++++++++++++++++++++++++++++++++++++
> >> > tests/qtest/meson.build    |   1 +
> >> > 3 files changed, 426 insertions(+)
> >> > create mode 100644 tests/qtest/flexcan-test.c
> >> >
> >> >diff --git a/MAINTAINERS b/MAINTAINERS
> >> >index e723863a6f..dbb159f031 100644
> >> >--- a/MAINTAINERS
> >> >+++ b/MAINTAINERS
> >> >@@ -2090,6 +2090,7 @@ S: Maintained
> >> > F: hw/net/can/flexcan.c
> >> > F: hw/net/can/flexcan_regs.h
> >> > F: include/hw/net/flexcan.h
> >> >+F: tests/qtest/flexcan-test.c
> >> > 
> >> > EDU
> >> > M: Jiri Slaby <jslaby@suse.cz>
> >> >diff --git a/tests/qtest/flexcan-test.c b/tests/qtest/flexcan-test.c
> >> >new file mode 100644
> >> >index 0000000000..b5880d4119
> >> >--- /dev/null
> >> >+++ b/tests/qtest/flexcan-test.c
> >> >@@ -0,0 +1,424 @@
> >> >+/*
> >> >+ * QTests for FlexCAN CAN controller device model
> >> >+ *
> >> >+ * Copyright (c) 2025 Matyas Bobek <matyas.bobek@gmail.com>
> >> >+ *
> >> >+ * This code is licensed under the GPL version 2 or later.  See
> >> >+ * the COPYING file in the top-level directory.
> >> 
> >> IIUC this license text is redundant to the specifier below, but again, IANAL. Daniel?
> >
> >checkpatch.pl  should complain about this.
> >
> >For *newly* written files, only the SPDX-License-Identifier should be
> >present.   Traditional license boilerplate is only permitted if we're
> >dealing with historical files where we're required to preserve existing
> >license text.
> 
> Thanks for the hint!
> 
> Though checkpatch.pl doesn't seem to catch this particular case. Is a patch needed here?

Yeah, it seems it is slightly different enough to miss our
checks. If you want, you can submit another addition to the
@LICENSE_BOILERPLATE list in checkpatch.pl


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|