Re: [GSoC] Convert “git stash” to builtin proposal

[Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>]

On 25.03.2018 12:46, Christian Couder wrote:
> On Sat, Mar 24, 2018 at 8:31 PM, Paul-Sebastian Ungureanu
> <ungureanupaulsebastian@gmail.com> wrote:
>> On 23.03.2018 19:11, Christian Couder wrote:
>>
>>>> * Ensure that no regression occurred: considering that there are plenty
>>>> of tests and that I have a good understanding of the function, this
>>>> should be a trivial task.
>>>
>>> There are a lot of things that the test suite doesn't test.
>>
>> Hopefully, by first adding new tests, any eventual bug will be spotted.
> 
> I was thinking about things like memory leaks that tests cannot easily spot.> 

I will do my best and follow best practices in order to avoid any memory 
leaks. However, to make sure that my code is really leak free, I will 
use Valgrind, which is already integrated with the testing framework.

> Ok. Feel free to resend another version of your proposal.
Sorry for not sending the whole proposal again. I decided to send only 
the changed parts because the proposal is quite big and I wanted to 
avoid sending the same thing over and over again.

One thing I did not mention in the previous reply was that I also added 
a new paragraph to "Benefits to community" about 'git stash' being slow 
on Windows for a lot of users. I consider this alone to be a very good 
justification for this project and doing this project will be very 
beneficial for the Windows users.

Best regards,
Paul Ungureanu