From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B3E1C7EE30 for ; Fri, 3 Mar 2023 21:39:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231747AbjCCVjD (ORCPT ); Fri, 3 Mar 2023 16:39:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231836AbjCCVjB (ORCPT ); Fri, 3 Mar 2023 16:39:01 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1519B2702 for ; Fri, 3 Mar 2023 13:38:54 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id y15-20020a17090aa40f00b00237ad8ee3a0so3605166pjp.2 for ; Fri, 03 Mar 2023 13:38:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677879533; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2puE/sz7mhf/tFMRa6sCRYx7GxKMnQsV6q7967Bt4bw=; b=fUVpG6PsNWdrexTQddpH6er1gkrS7Qo+hesLT33AcRxHJ6C+nvFYaHBv94uC5L/GFG uyp6jaAJYQQJpbFblAgiG7x/bUwGK767CpT6f7LvM+JLdtGFSSSlInzGuO9/lYB9/wDY FNpa0qZfG5j3AO+RTKfM+E0Xt3+5BpG7ua5SDEXyDvetcAk7k/vtg3cZXuR+dTlhf8bH qVSr2+rdaaaf5MKDqeA5MBrXXCq1ywjD8G6PF9B3s4puU8F9qAMJaOMOxUjbsX402LdP Al4e88ns8u1sXEGe29g/dIU0vAUIS2EPSHPIsWc3sFvoysWQW/AqsRiHKamh4SzZZbhz zZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677879533; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2puE/sz7mhf/tFMRa6sCRYx7GxKMnQsV6q7967Bt4bw=; b=jgJh+HEr+YQzwJDGi8O8s1qb7moNFLchyJ4R85dNvK0y/Qpbb1M//OGZoVztd/yOMc FE6qRV3cH/hQyVbthA8s6BOVhBBh/wlFHt6EUnla/nYqJLJ/9C6Xx4maRk/V0NlIkap5 dwzYmjyoaEAZ8E3G18nawuQKvKjA4TdmO2nl9tSXx189z1+SEwznO3XMTyXuefObwb7d VhRFCjRxzDrVH0aQsJtMe/CdxQ1IqEVbXi7PS6J2kq08LMCQlYrVWltC608L7SeoqsY2 tKN1H3+kRvnvat+2nKcMPETrQqpAGWAIvyWD9sMccc55HNum3pQGSxGrLzi492yIdLQ9 XqfA== X-Gm-Message-State: AO0yUKUOhKXH3iFbotDyprDkOgA0MwxWH2xbcexIod97iXvK4xzx1zRT 4czJ5jSJaqfxrWDFJFIIuMo= X-Google-Smtp-Source: AK7set/8Y13uZ6KTcnaZilw0kqRF+kJ+xVBAsTvHCEMizKDbPAM9bupB/kAxIaWVR5c5OqGKdCDVuQ== X-Received: by 2002:a05:6a20:3c88:b0:cd:1c8e:cd44 with SMTP id b8-20020a056a203c8800b000cd1c8ecd44mr4407279pzj.47.1677879533395; Fri, 03 Mar 2023 13:38:53 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id r15-20020a63a54f000000b004fadb547d0csm1991844pgu.61.2023.03.03.13.38.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 13:38:52 -0800 (PST) Message-ID: Date: Fri, 3 Mar 2023 13:38:49 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 07/34] watchdog: bcm2835: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Wim Van Sebroeck , Guenter Roeck , Ray Jui , Scott Branden Cc: Broadcom internal kernel review list , linux-watchdog@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de References: <20230303213716.2123717-1-u.kleine-koenig@pengutronix.de> <20230303213716.2123717-8-u.kleine-koenig@pengutronix.de> From: Florian Fainelli In-Reply-To: <20230303213716.2123717-8-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 3/3/23 13:36, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Florian Fainelli -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38818C64EC4 for ; Fri, 3 Mar 2023 21:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w/h8SEY4j+NZa8jaUaNxwCXPEkbymS/wiJ1Avmb60Sk=; b=KQNTOtRVHGIswc XBfhxPKeS6K8wUlBP2vJejYHIJR7KAnX+0Bp9zlXGdORxPn4TlBFZlzx+Arh/2KyQ+OiPNFF4q4MY AJWPTG07K8gUGNH4PXbYH0iIDb0ckj6ItuaqQq6ac6apRrKSkkIdDo2fD5N7WWAAZ6E+S7En5x73Z KjLMXPwGpo7Zy2a6It9luPPLGtBNv48wjcrZRFtgtDYd6FON8UnhjHCEVisPk2cqw+jDuPggzqwq2 Fb6/xt756W5eyM2sKuuc+EoyZbxhQaoIcptQjNyRYNIcVCXDkLqCvdaatGGuHWtHBaDIXq/qW3bpO AqeiNpwytouklNQz9zSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYD7V-007UGk-SB; Fri, 03 Mar 2023 21:39:18 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYD79-007U2l-Dw; Fri, 03 Mar 2023 21:38:57 +0000 Received: by mail-pj1-x102b.google.com with SMTP id ce8-20020a17090aff0800b0023a61cff2c6so3122546pjb.0; Fri, 03 Mar 2023 13:38:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677879533; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2puE/sz7mhf/tFMRa6sCRYx7GxKMnQsV6q7967Bt4bw=; b=fUVpG6PsNWdrexTQddpH6er1gkrS7Qo+hesLT33AcRxHJ6C+nvFYaHBv94uC5L/GFG uyp6jaAJYQQJpbFblAgiG7x/bUwGK767CpT6f7LvM+JLdtGFSSSlInzGuO9/lYB9/wDY FNpa0qZfG5j3AO+RTKfM+E0Xt3+5BpG7ua5SDEXyDvetcAk7k/vtg3cZXuR+dTlhf8bH qVSr2+rdaaaf5MKDqeA5MBrXXCq1ywjD8G6PF9B3s4puU8F9qAMJaOMOxUjbsX402LdP Al4e88ns8u1sXEGe29g/dIU0vAUIS2EPSHPIsWc3sFvoysWQW/AqsRiHKamh4SzZZbhz zZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677879533; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2puE/sz7mhf/tFMRa6sCRYx7GxKMnQsV6q7967Bt4bw=; b=vEwet7Frid+fBai+dXyjJ/Ng+CXXz9P4MZdiL5UaHq/347BxgM0NEdZndoyJXOMK9Q 35kvbb4rOAGNOE+e7dbgXULZazzskQkd0hPniMU17yum5jNVLt2iamhVGg5Rq56XcwMb t+LYMuCS12SlEqFEvlSCV9NlszYWcsIis9FXP2hj+mh3hyUQWtQrnHvp62n093MjxguK 5MLkTaWGFUkEZQP9fz7r0Ji5FRznwUkkZRcmAUl0/0FyO8MA2Vd5cuk5n3BI7dUX7IxB t/ZWq0dPoxxr6ePeFtOZ4/iQWa9ZNjsDr8iEb4dGH0jtJZptSMLy56WmlGTmbZZMxDNt b9ZQ== X-Gm-Message-State: AO0yUKXWuOvVwcQslllZj1Zow77Xx/T/7bydXW03IE6M74iyDBaMjbis WvcyCzcapT//ZbXRkpJ01Vs= X-Google-Smtp-Source: AK7set/8Y13uZ6KTcnaZilw0kqRF+kJ+xVBAsTvHCEMizKDbPAM9bupB/kAxIaWVR5c5OqGKdCDVuQ== X-Received: by 2002:a05:6a20:3c88:b0:cd:1c8e:cd44 with SMTP id b8-20020a056a203c8800b000cd1c8ecd44mr4407279pzj.47.1677879533395; Fri, 03 Mar 2023 13:38:53 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id r15-20020a63a54f000000b004fadb547d0csm1991844pgu.61.2023.03.03.13.38.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 13:38:52 -0800 (PST) Message-ID: Date: Fri, 3 Mar 2023 13:38:49 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 07/34] watchdog: bcm2835: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Wim Van Sebroeck , Guenter Roeck , Ray Jui , Scott Branden Cc: Broadcom internal kernel review list , linux-watchdog@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de References: <20230303213716.2123717-1-u.kleine-koenig@pengutronix.de> <20230303213716.2123717-8-u.kleine-koenig@pengutronix.de> From: Florian Fainelli In-Reply-To: <20230303213716.2123717-8-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_133855_530864_75DA294B X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMy8zLzIzIDEzOjM2LCBVd2UgS2xlaW5lLUvDtm5pZyB3cm90ZToKPiBUaGUgLnJlbW92ZSgp IGNhbGxiYWNrIGZvciBhIHBsYXRmb3JtIGRyaXZlciByZXR1cm5zIGFuIGludCB3aGljaCBtYWtl cwo+IG1hbnkgZHJpdmVyIGF1dGhvcnMgd3JvbmdseSBhc3N1bWUgaXQncyBwb3NzaWJsZSB0byBk byBlcnJvciBoYW5kbGluZyBieQo+IHJldHVybmluZyBhbiBlcnJvciBjb2RlLiBIb3dldmVyIHRo ZSB2YWx1ZSByZXR1cm5lZCBpcyAobW9zdGx5KSBpZ25vcmVkCj4gYW5kIHRoaXMgdHlwaWNhbGx5 IHJlc3VsdHMgaW4gcmVzb3VyY2UgbGVha3MuIFRvIGltcHJvdmUgaGVyZSB0aGVyZSBpcyBhCj4g cXVlc3QgdG8gbWFrZSB0aGUgcmVtb3ZlIGNhbGxiYWNrIHJldHVybiB2b2lkLiBJbiB0aGUgZmly c3Qgc3RlcCBvZiB0aGlzCj4gcXVlc3QgYWxsIGRyaXZlcnMgYXJlIGNvbnZlcnRlZCB0byAucmVt b3ZlX25ldygpIHdoaWNoIGFscmVhZHkgcmV0dXJucwo+IHZvaWQuCj4gCj4gVHJpdmlhbGx5IGNv bnZlcnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJlbW92 ZQo+IGNhbGxiYWNrIHRvIHRoZSB2b2lkIHJldHVybmluZyB2YXJpYW50Lgo+IAo+IFNpZ25lZC1v ZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+ CgpSZXZpZXdlZC1ieTogRmxvcmlhbiBGYWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+Ci0t IApGbG9yaWFuCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=