From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Arnd Bergmann <arnd@arndb.de>, Max Kellermann <max@duempel.org>,
Shuah Khan <shuah@kernel.org>,
Malcolm Priestley <tvboxspy@gmail.com>,
Michael Ira Krufky <mkrufky@linuxtv.org>,
Abhilash Jindal <klock.android@gmail.com>,
Xiubo Li <lixiubo@cmss.chinamobile.com>
Subject: Re: [PATCH 11/25] [media] dvb-core: use pr_foo() instead of printk()
Date: Fri, 14 Oct 2016 20:22:40 +0200 [thread overview]
Message-ID: <ad6e8052-d9e2-e5bd-1c19-f402c04007ea@users.sourceforge.net> (raw)
In-Reply-To: <1d5040384c93e1cb37dd41e780e44a88b1e63ce4.1476466574.git.mchehab@s-opensource.com>
> diff --git a/drivers/media/dvb-core/dmxdev.c b/drivers/media/dvb-core/dmxdev.c
> index 7b67e1dd97fd..1e96a6f1b6f0 100644
> --- a/drivers/media/dvb-core/dmxdev.c
> +++ b/drivers/media/dvb-core/dmxdev.c
> @@ -20,6 +20,8 @@
> *
> */
>
> +#define pr_fmt(fmt) "dmxdev: " fmt
> +
> #include <linux/sched.h>
> #include <linux/spinlock.h>
> #include <linux/slab.h>
How do you think to use an approach like the following there?
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
or eventually
+#define MY_LOG_PREFIX KBUILD_MODNAME ": "
+#define pr_fmt(fmt) MY_LOG_PREFIX fmt
Regards,
Markus
next prev parent reply other threads:[~2016-10-14 18:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 17:45 [PATCH 00/25] Do some printk cleanups to avoid troubles with continuation lines Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 01/25] [media] tuner-xc2028: mark printk continuation lines as such Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 02/25] [media] tuner-xc2028: don't break long lines Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 03/25] [media] em28xx: " Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 04/25] [media] em28xx: mark printk continuation lines as such Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 05/25] [media] em28xx: use pr_foo instead of em28xx-specific printk macros Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 06/25] [media] em28xx: convert the remaining printks to pr_foo Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 07/25] [media] dvb-core: don't break long lines Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 08/25] [media] tuner-core: " Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 09/25] [media] tuner-core: use %&ph for small buffer dumps Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 10/25] [media] radio-bcm2048: don't ignore errors Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 11/25] [media] dvb-core: use pr_foo() instead of printk() Mauro Carvalho Chehab
2016-10-14 18:22 ` SF Markus Elfring [this message]
2016-10-21 10:34 ` Mauro Carvalho Chehab
2016-10-14 20:15 ` Arnd Bergmann
2016-10-14 17:45 ` [PATCH 12/25] [media] dvb_demux: convert an internal ifdef into a Kconfig option Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 13/25] [media] dvb_demux: uncomment a packet loss check code Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 14/25] [media] dvb-core: get rid of demux optional circular buffer Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 15/25] [media] dvb-core: move dvb_filter out of the DVB core Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 16/25] [media] dvb_filter: get rid of dead code Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 17/25] [media] dvb_filter: use KERN_CONT where needed Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 18/25] [media] uvc_driver: " Mauro Carvalho Chehab
2016-10-17 13:50 ` Laurent Pinchart
2016-10-14 17:45 ` [PATCH 19/25] [media] imon: use %*ph to do small hexa dumps Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 20/25] [media] mt20xx: " Mauro Carvalho Chehab
2016-10-14 17:45 ` [PATCH 21/25] [media] tvaudio: mark printk continuation lines as such Mauro Carvalho Chehab
2016-10-14 17:46 ` [PATCH 22/25] [media] flexcop-i2c: " Mauro Carvalho Chehab
2016-10-14 17:46 ` [PATCH 23/25] [media] cx2341x: " Mauro Carvalho Chehab
2016-10-14 17:46 ` [PATCH 24/25] [media] dvb-pll: use pr_foo() macros instead of printk() Mauro Carvalho Chehab
2016-10-14 17:46 ` [PATCH 25/25] [media] nxt6000: " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad6e8052-d9e2-e5bd-1c19-f402c04007ea@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=arnd@arndb.de \
--cc=hans.verkuil@cisco.com \
--cc=klock.android@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
--cc=max@duempel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=shuah@kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.