From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BC0CC43217 for ; Mon, 7 Nov 2022 18:05:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EE18084F66; Mon, 7 Nov 2022 19:05:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=siemens.com header.i=@siemens.com header.b="VoTT9ni9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 89CB584F61; Mon, 7 Nov 2022 19:05:28 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20089.outbound.protection.outlook.com [40.107.2.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 453F384F9D for ; Mon, 7 Nov 2022 19:05:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DzF8eIVptzK0wUI3D6sVki6z7ENcZ5iRaSRqCDCz5Ty8Iom10niFueAzAhjpOAwAaHA6gjlyfJ5+1uLwpKe7lBv5H73UtfNeOT7C4VxAvr3fmbbbuVm6WsW0Zx7+PF6cuwlPA3ZB1ATmknd2peU2b8aBhx0AZv99nE0lkrX9ui42LfgMZ4ID7k/QmdwyVH3ZshPABd/9XrxgB5scqMPh26R90hNtp+4+g22HFhIWOm29+PdtVGzqVYzVcgigbk1c1l6B7MTVKtuka30VHLsyey4e5exK5JUFkh8goC8ZidVw3Hh3VkstRny08NjQNAKYlfkt1wE8vH4ZqHD1faVHRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7mCf6Z13k2vZfdvD8Zn9DrPVulBFRxf0XVPoGqH+FOw=; b=bcK7CWSX+//vKtZMK+cS2hQLfJNxBgBecxrLMgmLU777frartJcXQFaNpZWz7gkt2VTZhXm6FWpaCPAIjbpmfdoTjgAEkYJvEviS9IP2r8pEb1nv1CMe2oD303FiMNSTa4xgknvQ7YKxUAzsbIY0KMR1Aoc7PNTDnSvP4g6RwhsfR+z5mOywV4vVcL0Rasffl5Nv7TgRPo3VeD5os7Ot9HUJumXW3jWivFxTlzX4xsrmirXVIQpFTM6pDHa7IhEkm8x5HdxviXCPqlMoyJ3JHhlMldQHRd8W3hSk+NYO6JJAfQDBBW6iECuXYWtF84L19YWOyjXBUwMr/gp/h3I13g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7mCf6Z13k2vZfdvD8Zn9DrPVulBFRxf0XVPoGqH+FOw=; b=VoTT9ni9u67zfMLhT5+WY0wKMM+kUWj6xsiBLy2rcVU414ptN4ZC7/9u29+gFPmNPJvWtvcmn9+KJrvkdz8gGTn98h+0Dllo1gu5I0KRRKBbqEtyOwQducXRL2dixAqrnv6uPTdmLJ1KqjgbZ+uz6QuQzBEDCCfKoDbHJ8Hp5vcmUxbDDlpLh+ITLZafLZsekOTNXiAeMCw3BGATvLJbh6OnoxhL5lR6vekR/N8wSy2s5E2ZCc8TcI0JlZ0NTEUzB/b2QjzRO/wd+p6SVpr1mdGYS9fvKDwBM5/bP4wsUVJUTPKw+z3+epDUyE0Fq0BeJZTyETaxjqWEMq9cXESKPA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by GV1PR10MB6348.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:a1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 18:05:23 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::5d9b:b9d1:bd69:107b]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::5d9b:b9d1:bd69:107b%4]) with mapi id 15.20.5791.025; Mon, 7 Nov 2022 18:05:23 +0000 Message-ID: Date: Mon, 7 Nov 2022 19:05:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3 2/3] efi_loader: Set default console colors on efi_cout_clear_screen if needed Content-Language: en-US To: Heinrich Schuchardt Cc: U-Boot Mailing List , Ilias Apalodimas References: <4b7a28d04119ae529a2dc1a16dec50fb39c74f17.1667549199.git.jan.kiszka@siemens.com> From: Jan Kiszka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0503.eurprd06.prod.outlook.com (2603:10a6:20b:49b::28) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|GV1PR10MB6348:EE_ X-MS-Office365-Filtering-Correlation-Id: 6719ec0a-5128-4aed-77f8-08dac0eaa434 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TkpqxIgEKKMN8pX8Dkku1DQDe8AWCY58fcvAxy0a3ghJrPY8ONzJx5XWqaCwvDodfMCBuE6QC5jdXlsD5kOcUazVlDq7HcrCdi5A+pjLdZ2VaXYCJQpB4+IUX7dgdZ7bGLotokI8fUZPKoGe3HJ+et7GcYwqeg141nFPzvzqpDTgQdiljn4y5cPIT2pow06U6X1sZfaVwSOqZY3KBUokxifZ1Q1LELtKchW5hEd7px4bWk+JWD/TjxqDgqwBEaJ7QvcwMVwCybpS6Yn/mh8nBNRIZqtb7r8d+f548SHFRbzbalZgah/r+CMePmTpRwb8W8yEq1fO0q8BSCLt8iXfeXkzbnocdXmUyZRfwr9NAvzdXBpYB+lxT1vfB/jntOzasAZ/yib9ba7sT4/dVgdKTbYh8ZEVvUlvSutTQn6htZIfwbT9pdXB1VZ32xXeJbtzeTsuqEIXzS1tagmSDKnngXGzOKMCK/rmmqCQLfV0evN6YshUvFvSzPrEDrQWrPi+3pWmABNS6reI+hb/2OTocDHBy8VslxmUCmX2QI/Mqc2T1G2PW2jTrIn+wZ68DMJeMQ2Sa4dNtDSkDoLOwfOm34tOysS6lDGq9CWh7FlIqKVvWZh10mkP4T+cF0oTesBkvaIlMhMjhsRF5N9GyXTXXSqVS8v14Y46i4jBAkiSxL1XqQ8cnCe5pOGIUZpGo1/X7b1K/X07TD/1BlU2/nrY1r8qLRbdIxfTssC7wgDBmZB56sgftyAqRZFVQ9XGdRbyxWG7YRztHGR8rH0ref1ot384KN0iI61riYAArTc4BaAS0Lk6troq6nJhsfpfSRp9 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(6506007)(53546011)(54906003)(316002)(5660300002)(2906002)(2616005)(6916009)(83380400001)(186003)(8936002)(44832011)(16799955002)(26005)(6512007)(36756003)(31696002)(66476007)(4326008)(66556008)(8676002)(66946007)(86362001)(41300700001)(82960400001)(6486002)(966005)(38100700002)(31686004)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2NYWEpJQWYyd0hKTDdZYmNZRXUrNE9DZ1ZuR0hrYlNaY1BPNzNwN1dHZ1dK?= =?utf-8?B?eHd3dkVCaFgxZ2RNbnNnNE1xZ2h3UXJrMnZMbFNrNDI3QnoxTDFZbWI3SnFw?= =?utf-8?B?bm9FQlJVV3NERDhWRTZKcWR0RXhINnZJU1JlbDNQUVRPK1lWUndBL3BobnlC?= =?utf-8?B?TEEzOTVqV1lFQkdtNVBoVXlsRWJKQ2FxYndRQWNiVHFRSFhSZjdpb2lYbGRH?= =?utf-8?B?am1hRm91Q0hudCtqSkpFQ0tmblhRT3IzZThhNmV2V09tS1luaWQyQUxZUVpx?= =?utf-8?B?WDBjRWlZR2p4LzU4ejV3N1dvdUNheFprTTRtaUVzeUFJQ0M5cC9YdXN4cFVs?= =?utf-8?B?dDhOTGZsOXNKVGxnUlpmRzd4RDErNnFGeE5oR2UrdWVjeXZTNzMyclU3akxz?= =?utf-8?B?dXltbE55UHlYNlI0Zm1kUXQxRjM2RE9TbFV6MzgzanIrL3l2MXNCSGZGSm5J?= =?utf-8?B?UFNxbGhVWGtWa0hWTS9McHhmUXVXWmJQQ0pOUndaYTE5Vlh1N3RtNmtzQWpL?= =?utf-8?B?ZlVWT1VNZlJhNlAwYjJUc1hTYUdzaC83WGVOeWRNWmNMNlR3YkFOVC9CWDNP?= =?utf-8?B?UU93TFA0cEtwS1pKcE1zYlhQQ3MrbDE3QVl4OEZKSzJUMDhEaXlaWS96eUtS?= =?utf-8?B?ZlJ0UWkzczlxY0VYeHV2WHZjbC9uMWdta0VESmpTR3JqZnEybFp6L0Fqb1Bw?= =?utf-8?B?anhFdmtDMXRZZ3cyU0V5STFoNllyU1M4dFMwbFlHeFVrd2FCSnhlM1RjaXRZ?= =?utf-8?B?Y2N2VGFlRUxRbTZGUFZoUjErcjlYbHZrN2J5YnJYaHVVc1lvU3lSendKVnMv?= =?utf-8?B?R3ErcEtJNWJjcHJyVGRUZlJxU2VYV3U0WWhwY3JRcUVObFhNYWMyUiszZG8v?= =?utf-8?B?YkR6NjFMUCtZS2JQa3VzYzFNRFUxL3FFMDNPQlF6RmFwQTlOYThPYW1oM2RH?= =?utf-8?B?SG1leWNNZzFmejM5dlZXaDhKby9Ta0dNNlZYN0RQNUVpZFNldVhaNG9NaXhz?= =?utf-8?B?OUlidWdHeE5NZmt3L2RpdlZSM0tDd3NOem1iWVhWQ1dpdEN0bXI3K002NzJC?= =?utf-8?B?dWx0MWZBbldiVjJYWUJHSXg5OWtsL2NXbE11UGxCeituYTFQUFRJY3JTaUkw?= =?utf-8?B?bTFxbHU3dzhEL05tcUF5Tkd0OVlJTFNOcWxxU1ZpMEhJV0p6KzdUN2s2VE9D?= =?utf-8?B?Q0kwU1NLYi9qMTQvSEJMUTlyV0kra0Mza3FiTk5BYzNKeDZheElxcFBVeHRW?= =?utf-8?B?Z0RZL0hpb2t1dlRkMkhDUmNVd0pMTEVudXNFMVVPSjRKMWZSRlJWaTUwUVYv?= =?utf-8?B?WEFrbGF3c21WV2V3R3AyWlo5VG9jQXlNbk4zajlEa0Rvd0RFSzhibDJKOWcz?= =?utf-8?B?WnJqc1l1V0FjQldxYUxHT2hXMWZGNkRINWozMDNKOWZjd3Z3bmdTMUgyQUFQ?= =?utf-8?B?OFpSL1E5Ykl5MVJlTlBRNGhGdXUvclB5VU05Z21ldmUxNnpBdWE0Wk5sUW01?= =?utf-8?B?VWZOeHJpKzJydEFHWFZVczNtaXM5cU9NZFZWblVIbzlleG15N293WWFheDdu?= =?utf-8?B?L0puSGhuZ2hZSm9DMlkrV1RjVUFYRGlzQnBmS3VQSHhrcHhQNm9QNHJCV1Bz?= =?utf-8?B?K0dRai9XSWdvdVIxcEp4bDd6dW9WbWNyL3E1bE5naFB6OEg5TU9DZ0tMZ3BX?= =?utf-8?B?ZVJTSEl0aWU3emRYYXFkcGMyZmNHOUQvY0VaQUZISSszV1ljUWpYUzRuazg1?= =?utf-8?B?RXdmNzkrOTZia3NnM2tGREszT2Q0WVB5VGlZL1B3THBTMmZiY3ZRc3ZpM2lQ?= =?utf-8?B?d25GN3ZNMXlkZEdIV2E0VlJBOEI1ei93MEJ3Y1g5dDZ1SllFWENRaXMzSGFi?= =?utf-8?B?ZGM2S0N6QTFTRDZQR0g2aFBtU2F6Lzg3N1FrOFJFUkhHQ1pZQ01ZVGFmQTFX?= =?utf-8?B?aENKb0pqclU2cGhJMkpJSlBvdWM5aUtpc2hPQlJ6L1hOdHlZQjVlL3pLdUNV?= =?utf-8?B?ejMya002VVYycDFPd0V4RFJDQXVIK0JLOGIvRFZSaENneGVicmdDbzJMTS9Z?= =?utf-8?B?VWRCZmdsUzhYS0oraWVFN0FEajk3MlAwbkY4RUF2ZmFweGtrTzNsSk0rQklp?= =?utf-8?B?Si96UlBaaUU4UUVuOWpVeGlxMHRwRW82cDZmdGg4ejZQV3JlWjFMTy9TM3B1?= =?utf-8?B?VlE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6719ec0a-5128-4aed-77f8-08dac0eaa434 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 18:05:23.7221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U7JltwaKc+qtEInVkaBjRpOv3Wbtwes4m5xqldXr/Bh9QLKY65dNZZjkUrJowgtDOGE/JnROhWMGw+W5m/G52Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB6348 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 07.11.22 18:06, Heinrich Schuchardt wrote: > On 11/4/22 09:06, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Ensures a consistent background color of the whole screen for succeeding >> outputs as both demanded by the spec and implemented in EDK2 as well. > > To which sentence in the UEFI 2.10 spec are you relating? > 12.4: "EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.ClearScreen() Clears the output device(s) display to the currently selected background color." That generally works - except for this default case. >> >> Signed-off-by: Jan Kiszka >> --- >>   lib/efi_loader/efi_console.c | 6 ++++++ >>   1 file changed, 6 insertions(+) >> >> diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c >> index 6ce0fcc168d..4228a509caf 100644 >> --- a/lib/efi_loader/efi_console.c >> +++ b/lib/efi_loader/efi_console.c >> @@ -495,6 +495,12 @@ static efi_status_t EFIAPI efi_cout_clear_screen( >>   { >>       EFI_ENTRY("%p", this); >> >> +    /* Set default colors if not done yet */ >> +    if (efi_con_mode.attribute == 0) { >> +        efi_con_mode.attribute = 0x07; >> +        printf(ESC "[0;37;40m"); > > These values are correct for CONFIG_SYS_WHITE_ON_BLACK=y. But for > CONFIG_SYS_WHITE_ON_BLACK=n I would expect black letters on white as > default. > > This requires adding support background color values 100 - 107 (cf. > https://en.wikipedia.org/w/index.php?title=ANSI_escape_code§ion=15#3-bit_and_4-bit) > in vidconsole_escape_char(). > > UEFI background color white should be translated to 107 if > CONFIG_SYS_WHITE_ON_BLACK=n. I don't think we handle CONFIG_SYS_WHITE_ON_BLACK=n in UEFI so far. It likely requires translating all colors that apps so far select. Otherwise, you will end up with white-on-EFI_WHITE. > > It seems this patch is trying to solve a problem caused by patch 1 of > the series. Or do I miss something? Not at all, problem persists if you drop that patch. I've accidentally accounted to "efi_loader: avoid EFI_CALL() for clearing screen", see https://lore.kernel.org/u-boot/532ff3e2-06ba-3a3e-5cf9-2f4a9b7abb8c@siemens.com/ for a screen shot. Jan -- Siemens AG, Technology Competence Center Embedded Linux