From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Thomas Pedersen <thomas@eero.com>
Cc: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] mac80211: clear failure average upon mesh path deactivation
Date: Tue, 31 Jan 2017 11:53:40 -0800 [thread overview]
Message-ID: <ad799cb0f89a70c0dd096af89363e8ca@codeaurora.org> (raw)
In-Reply-To: <CADjYELxQw17B5Oa8rwh5bNs-M4SgkCwKKxFAT2m=5UD44A+e8Q@mail.gmail.com>
On 2017-01-31 11:46, Thomas Pedersen wrote:
> On Tue, Jan 31, 2017 at 11:33 AM, Rajkumar Manoharan wrote:
>> On 2017-01-31 09:51, Thomas Pedersen wrote:
>>>
[...]
>>>> + if (paths_deactivated)
>>>> + sta->mesh->fail_avg = 0;
>>>
>>>
>>> .. why this indirection? Just reset mesh->fail_avg unconditionally in
>>> this function?
>>>
>> Hmm... As fixed paths are not affected, resetting fail_avg for fixed
>> path
>> may give
>> wrong metric. no?
>
> I don't think setting fail_avg = 0 will affect existing fixed mpath
> code. Anyway metrics should not
> affect whether a fixed mpath is chosen.
>
Great. Will remove conditional check. Thanks for your feedback Thomas.
-Rajkumar
prev parent reply other threads:[~2017-01-31 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 0:01 [PATCH 1/3] mac80211: fix mesh moving average stuck Rajkumar Manoharan
2017-01-28 0:01 ` [PATCH 2/3] mac80211: Make mesh failure moving average configurable Rajkumar Manoharan
2017-01-28 0:01 ` [PATCH 3/3] mac80211: clear failure average upon mesh path deactivation Rajkumar Manoharan
2017-01-31 17:51 ` Thomas Pedersen
2017-01-31 19:33 ` Rajkumar Manoharan
2017-01-31 19:46 ` Thomas Pedersen
2017-01-31 19:53 ` Rajkumar Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad799cb0f89a70c0dd096af89363e8ca@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qca.qualcomm.com \
--cc=thomas@eero.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.