Re: [PATCH v2 5/5] drm/panthor: Don't update MMU_INT_MASK in panthor_mmu_irq_handler()

[Steven Price <steven.price@arm.com>]

On 01/04/2025 19:23, Boris Brezillon wrote:
> Interrupts are automatically unmasked in
> panthor_mmu_irq_threaded_handler() when the handler returns. Unmasking
> prematurely might generate spurious interrupts if the IRQ line is
> shared.
> 
> Changes in v2:
> - New patch
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>

Reviewed-by: Steven Price <steven.price@arm.com>

> ---
>  drivers/gpu/drm/panthor/panthor_mmu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
> index 4ac95a31907d..7a7993016314 100644
> --- a/drivers/gpu/drm/panthor/panthor_mmu.c
> +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
> @@ -1719,7 +1719,6 @@ static void panthor_mmu_irq_handler(struct panthor_device *ptdev, u32 status)
>  		 * re-enabled.
>  		 */
>  		ptdev->mmu->irq.mask = new_int_mask;
> -		gpu_write(ptdev, MMU_INT_MASK, new_int_mask);
>  
>  		if (ptdev->mmu->as.slots[as].vm)
>  			ptdev->mmu->as.slots[as].vm->unhandled_fault = true;