From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta1.migadu.com (out-185.mta1.migadu.com [95.215.58.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 309F842AB7 for ; Fri, 24 May 2024 14:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716561512; cv=none; b=DuRoceqgt1DFQ87BAwFzafn6UIU/P0OJIFMFBvkspznW7AXSc3/wlovamyzVASjXMk125NYGtq+EV7V+LmTSNZEKViNob7K8+ZDwGWrhHiFB5p32u1qfddz00fwo2rMe1QgItkDCrf74fDl2UrFloMNts6fzJfUBfnSYTG20cDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716561512; c=relaxed/simple; bh=P0oGiXPwUYgxEc8MMGLYiqhD0U1U/yW8vDU6/y/HYA4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZvIZyLUKwRNl/X+AUXup9xC5r+IhO6+j4sWEM8+m+MfF29xERoHTt7D6klun4eYLwqNNAbHr2IVtUxMyYnIQ3q3iSaJi97AfHn5HwJOjdTgWBrH6Afgd5fKFzelrA+IDMnAvjTe0CB3QCf3Nz9VdENzyqNCabDQ8k7Xv/+JMcFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=W+6sNU+8; arc=none smtp.client-ip=95.215.58.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="W+6sNU+8" X-Envelope-To: markus.elfring@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716561508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KNBYTib7bUrTL43Ki1euUCce0RgdF7TpezQWmMPaS+0=; b=W+6sNU+8P+CQXEFhRbBWKO7eHkid0PNn/SrR8Ctd1eIuq/OVVzJbS8HWe469L3WfSuZSvW jv4AxCVIjSyIS1kVjuGpkGKjBhOvGeJEQhIYV9e3TFpCIX+JY6NIHRPZ+ibvMr8f8ZuqD4 f2QaMZbCPnVfA+1kzyv6TuGv0jbQqYg= X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: linux-pci@vger.kernel.org X-Envelope-To: kernel-janitors@vger.kernel.org X-Envelope-To: kw@linux.com X-Envelope-To: lpieralisi@kernel.org X-Envelope-To: robh@kernel.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: bharat.kumar.gogada@xilinx.com X-Envelope-To: bhelgaas@google.com X-Envelope-To: lorenzo.pieralisi@arm.com X-Envelope-To: michal.simek@amd.com X-Envelope-To: michal.simek@xilinx.com X-Envelope-To: thippeswamy.havalige@amd.com Message-ID: Date: Fri, 24 May 2024 10:38:23 -0400 Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 6/7] PCI: xilinx-nwl: Add phy support To: Markus Elfring , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org, =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Lorenzo Pieralisi , Rob Herring Cc: LKML , Bharat Kumar Gogada , Bjorn Helgaas , Lorenzo Pieralisi , Michal Simek , Michal Simek , Thippeswamy Havalige References: <20240520145402.2526481-7-sean.anderson@linux.dev> <89d6acd5-5008-4db3-927c-d267be7b9302@web.de> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <89d6acd5-5008-4db3-927c-d267be7b9302@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 5/24/24 04:16, Markus Elfring wrote: >> Add support for enabling/disabling PCIe phys. We can't really do >> anything about failures in the disable/remove path, so just warn. > … >> +++ b/drivers/pci/controller/pcie-xilinx-nwl.c > … >> @@ -818,12 +876,15 @@ static int nwl_pcie_probe(struct platform_device *pdev) >> err = nwl_pcie_enable_msi(pcie); >> if (err < 0) { >> dev_err(dev, "failed to enable MSI support: %d\n", err); >> - goto err_clk; >> + goto err_phy; >> } >> } >> >> err = pci_host_probe(bridge); >> >> +err_phy: >> + if (err) >> + nwl_pcie_phy_disable(pcie); >> err_clk: >> if (err) >> clk_disable_unprepare(pcie->clk); > > I got the impression that some source code adjustments should be performed > in another separate update step for this function implementation. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n81 > > You propose to extend the exception handling here. > Does such information indicate a need for another tag “Fixes”? Huh? I am only disabling what I enabled... --Sean From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39CB9C25B74 for ; Fri, 24 May 2024 14:38:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pKl3vQE3rS7BqydUe92/3wk8KO49yjVmYykV11K6LeU=; b=cbFjd36tA1G5u4 TvMFBcSw9Qq6oKyfMCQxTemj2McRy4t9VxXAbdTfAu2zMlfUKQStpdSJRa1N04gfp8X/vGZGtn6hY sdL1z/s6fJWp+YyZpJaAqibswB/X1ZIpIsI+zXiVoVh/LyGyCLzVOt9QRd4lSCXu7A8OWfdQ8XhGj pNGoY3wR4kFETsi6TWdhvwa03y7Y8LiHdSVyhcMCpOLy2M+lhZ74SrcoqIS4pUOtrPZ/TRgKvFhcl Lv8IxpQO8MfpUSz9mbyv4lExE/wfr8d7ZivXt0PZQ7/IztBvd3NyI3EAy2GqRYkHpogAH9oAcLknX amtVSrgv3O6Kb16+Xcnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sAW43-000000098eD-33k3; Fri, 24 May 2024 14:38:35 +0000 Received: from out-189.mta1.migadu.com ([2001:41d0:203:375::bd]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sAW3z-000000098dm-3Ajx for linux-arm-kernel@lists.infradead.org; Fri, 24 May 2024 14:38:34 +0000 X-Envelope-To: markus.elfring@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716561508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KNBYTib7bUrTL43Ki1euUCce0RgdF7TpezQWmMPaS+0=; b=W+6sNU+8P+CQXEFhRbBWKO7eHkid0PNn/SrR8Ctd1eIuq/OVVzJbS8HWe469L3WfSuZSvW jv4AxCVIjSyIS1kVjuGpkGKjBhOvGeJEQhIYV9e3TFpCIX+JY6NIHRPZ+ibvMr8f8ZuqD4 f2QaMZbCPnVfA+1kzyv6TuGv0jbQqYg= X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: linux-pci@vger.kernel.org X-Envelope-To: kernel-janitors@vger.kernel.org X-Envelope-To: kw@linux.com X-Envelope-To: lpieralisi@kernel.org X-Envelope-To: robh@kernel.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: bharat.kumar.gogada@xilinx.com X-Envelope-To: bhelgaas@google.com X-Envelope-To: lorenzo.pieralisi@arm.com X-Envelope-To: michal.simek@amd.com X-Envelope-To: michal.simek@xilinx.com X-Envelope-To: thippeswamy.havalige@amd.com Message-ID: Date: Fri, 24 May 2024 10:38:23 -0400 MIME-Version: 1.0 Subject: Re: [PATCH v3 6/7] PCI: xilinx-nwl: Add phy support To: Markus Elfring , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org, =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Lorenzo Pieralisi , Rob Herring Cc: LKML , Bharat Kumar Gogada , Bjorn Helgaas , Lorenzo Pieralisi , Michal Simek , Michal Simek , Thippeswamy Havalige References: <20240520145402.2526481-7-sean.anderson@linux.dev> <89d6acd5-5008-4db3-927c-d267be7b9302@web.de> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <89d6acd5-5008-4db3-927c-d267be7b9302@web.de> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240524_073832_281541_E9F91FCF X-CRM114-Status: GOOD ( 12.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gNS8yNC8yNCAwNDoxNiwgTWFya3VzIEVsZnJpbmcgd3JvdGU6Cj4+IEFkZCBzdXBwb3J0IGZv ciBlbmFibGluZy9kaXNhYmxpbmcgUENJZSBwaHlzLiBXZSBjYW4ndCByZWFsbHkgZG8KPj4gYW55 dGhpbmcgYWJvdXQgZmFpbHVyZXMgaW4gdGhlIGRpc2FibGUvcmVtb3ZlIHBhdGgsIHNvIGp1c3Qg d2Fybi4KPiDigKYKPj4gKysrIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2llLXhpbGlueC1u d2wuYwo+IOKApgo+PiBAQCAtODE4LDEyICs4NzYsMTUgQEAgc3RhdGljIGludCBud2xfcGNpZV9w cm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+PiAgCQllcnIgPSBud2xfcGNpZV9l bmFibGVfbXNpKHBjaWUpOwo+PiAgCQlpZiAoZXJyIDwgMCkgewo+PiAgCQkJZGV2X2VycihkZXYs ICJmYWlsZWQgdG8gZW5hYmxlIE1TSSBzdXBwb3J0OiAlZFxuIiwgZXJyKTsKPj4gLQkJCWdvdG8g ZXJyX2NsazsKPj4gKwkJCWdvdG8gZXJyX3BoeTsKPj4gIAkJfQo+PiAgCX0KPj4KPj4gIAllcnIg PSBwY2lfaG9zdF9wcm9iZShicmlkZ2UpOwo+Pgo+PiArZXJyX3BoeToKPj4gKwlpZiAoZXJyKQo+ PiArCQlud2xfcGNpZV9waHlfZGlzYWJsZShwY2llKTsKPj4gIGVycl9jbGs6Cj4+ICAJaWYgKGVy cikKPj4gIAkJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKHBjaWUtPmNsayk7Cj4gCj4gSSBnb3QgdGhl IGltcHJlc3Npb24gdGhhdCBzb21lIHNvdXJjZSBjb2RlIGFkanVzdG1lbnRzIHNob3VsZCBiZSBw ZXJmb3JtZWQKPiBpbiBhbm90aGVyIHNlcGFyYXRlIHVwZGF0ZSBzdGVwIGZvciB0aGlzIGZ1bmN0 aW9uIGltcGxlbWVudGF0aW9uLgo+IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51 eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL0RvY3VtZW50YXRpb24vcHJvY2Vz cy9zdWJtaXR0aW5nLXBhdGNoZXMucnN0P2g9djYuOSNuODEKPiAKPiBZb3UgcHJvcG9zZSB0byBl eHRlbmQgdGhlIGV4Y2VwdGlvbiBoYW5kbGluZyBoZXJlLgo+IERvZXMgc3VjaCBpbmZvcm1hdGlv biBpbmRpY2F0ZSBhIG5lZWQgZm9yIGFub3RoZXIgdGFnIOKAnEZpeGVz4oCdPwoKSHVoPyBJIGFt IG9ubHkgZGlzYWJsaW5nIHdoYXQgSSBlbmFibGVkLi4uCgotLVNlYW4KCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK