From: Yao Zi <me@ziyao.cc>
To: Lobanokivan11 <lobanokivan11@gmail.com>, u-boot@lists.denx.de
Cc: u-boot-qcom@groups.io, casey.connolly@linaro.org,
neil.armstrong@linaro.org, sumit.garg@kernel.org,
trini@konsulko.com
Subject: Re: [PATCH] xiaomi pad 5 support
Date: Sat, 4 Apr 2026 05:52:24 +0000 [thread overview]
Message-ID: <adCnGAUnLRcZExgp@pie> (raw)
In-Reply-To: <20260403160127.10605-1-lobanokivan11@gmail.com>
On Fri, Apr 03, 2026 at 07:01:26PM +0300, Lobanokivan11 wrote:
> ---
> board/qualcomm/xiaomi-nabu.env | 11 +
> configs/xiaomi-nabu_defconfig | 6 +
> dts/upstream/src/arm64/qcom/pm8150.dtsi | 10 +-
> dts/upstream/src/arm64/qcom/pm8150b.dtsi | 8 +
Devicetree (and bindings) in dts/ are pulled from devicetree
upstream[1] (i.e., Linux kernel), and you shouldn't directly modify
files in it. If you need a commit in dts upstream that hasn't
synchronized into U-Boot yet, tools/update-subtree.sh might be used for
cherry-picking one commit once it has landed in Linux master.
However, I don't see such changes to pm8150(b).dtsi in Linux 7.0-rc6, so
you might want to push the changes to Linux upstream first.
> .../src/arm64/qcom/sm8150-oneplus-common.dtsi | 545 ++++++++
> .../arm64/qcom/sm8150-oneplus-guacamole.dts | 70 +
> .../src/arm64/qcom/sm8150-oneplus-hotdogb.dts | 65 +
> .../src/arm64/qcom/sm8150-wcd9340.dtsi | 86 ++
> .../src/arm64/qcom/sm8150-xiaomi-cepheus.dts | 575 ++++++++
> .../src/arm64/qcom/sm8150-xiaomi-nabu.dts | 1175 +++++++++++++++++
> dts/upstream/src/arm64/qcom/sm8150.dtsi | 102 ++
> 11 files changed, 2652 insertions(+), 1 deletion(-)
> create mode 100644 board/qualcomm/xiaomi-nabu.env
> create mode 100644 configs/xiaomi-nabu_defconfig
> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-oneplus-common.dtsi
> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-oneplus-guacamole.dts
> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-oneplus-hotdogb.dts
> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-wcd9340.dtsi
> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-xiaomi-cepheus.dts
> create mode 100644 dts/upstream/src/arm64/qcom/sm8150-xiaomi-nabu.dts
What's the relationship between Xiaomi Pad 5 and
"oneplus-guacamole/hotdogb"? The latter doesn't seem to match subject of
the patch, which is "xiaomi pad 5 support". You probably want to have a
separate commit for the non-xiaomi stuff.
And, for the same reason as above, you should neither create files in
dts/ manually. I don't think these devicetrees have been in upstream,
either. An alternative is to put them in arch/arm/dts instead, but it'll
still be nice to have them upstreamed first.
...
> diff --git a/dts/upstream/src/arm64/qcom/pm8150.dtsi b/dts/upstream/src/arm64/qcom/pm8150.dtsi
> index d2568686a09..c3411b308e3 100644
> --- a/dts/upstream/src/arm64/qcom/pm8150.dtsi
> +++ b/dts/upstream/src/arm64/qcom/pm8150.dtsi
> @@ -116,13 +116,21 @@
> status = "disabled";
> };
>
> - rtc@6000 {
> + pm8150_rtc: rtc@6000 {
> compatible = "qcom,pm8941-rtc";
> reg = <0x6000>, <0x6100>;
> reg-names = "rtc", "alarm";
> interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
> };
It's possible to refer a devicetree node by using its full path, which
may help if you decide not to upstream changes in pm8150.dtsi first.
> + pm8150_sdam_2: sdam@b100 {
> + compatible = "qcom,spmi-sdam";
> + reg = <0xb100>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + status = "disabled";
> + };
> +
> pm8150_gpios: gpio@c000 {
> compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
> reg = <0xc000>;
Regards,
Yao Zi
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git
prev parent reply other threads:[~2026-04-04 5:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 16:01 [PATCH] xiaomi pad 5 support Lobanokivan11
2026-04-04 5:52 ` Yao Zi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adCnGAUnLRcZExgp@pie \
--to=me@ziyao.cc \
--cc=casey.connolly@linaro.org \
--cc=lobanokivan11@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=sumit.garg@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.