From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf test: Stat std output match 2 metrics for stalled-cycles-backend
Date: Mon, 6 Apr 2026 11:16:23 -0700 [thread overview]
Message-ID: <adP4dyKNTz3LjFmt@google.com> (raw)
In-Reply-To: <20260402220406.983248-1-irogers@google.com>
On Thu, Apr 02, 2026 at 03:04:06PM -0700, Ian Rogers wrote:
> Seen on ARM, the stalled-cycles-backend event can be given as the
> event for both backend_cycles_idle and stalled_cycles_per_instruction
> metrics. Make the metric match sufficiently generic to allow this.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/shell/stat+std_output.sh | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/stat+std_output.sh b/tools/perf/tests/shell/stat+std_output.sh
> index 9c4b92ecf448..5a6bda436dd4 100755
> --- a/tools/perf/tests/shell/stat+std_output.sh
> +++ b/tools/perf/tests/shell/stat+std_output.sh
> @@ -11,9 +11,12 @@ set -e
>
> stat_output=$(mktemp /tmp/__perf_test.stat_output.std.XXXXX)
>
> +# For event_name[i] expect to see event_metric[i]. 'stalled-cycles-backend' may
> +# match both 'backend_cycles_idle' and 'stalled_cycles_per_instruction', hence
> +# matching "_cycles_".
> event_name=(cpu-clock task-clock context-switches cpu-migrations page-faults stalled-cycles-frontend stalled-cycles-backend cycles instructions branches branch-misses)
> -event_metric=("CPUs_utilized" "CPUs_utilized" "cs/sec" "migrations/sec" "faults/sec" "frontend_cycles_idle" "backend_cycles_idle" "GHz" "insn_per_cycle" "/sec" "branch_miss_rate")
> -skip_metric=("tma_" "TopdownL1")
> +event_metric=("CPUs_utilized" "CPUs_utilized" "cs/sec" "migrations/sec" "faults/sec" "frontend_cycles_idle" "_cycles_" "GHz" "insn_per_cycle" "/sec" "branch_miss_rate")
Is this used for partial string match?
Then I guess "frontend_cycles_idle" can be covered by "_cycles_" too?
Also as we have "/sec", can "cs/sec" and "migrations/sec" be removed?
> +skip_metric=("tma_" "TopdownL1" "percent of slots")
Why is "percent of slots" added as well?
Thanks,
Namhyung
>
> cleanup() {
> rm -f "${stat_output}"
> --
> 2.53.0.1213.gd9a14994de-goog
>
next prev parent reply other threads:[~2026-04-06 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 22:04 [PATCH v1] perf test: Stat std output match 2 metrics for stalled-cycles-backend Ian Rogers
2026-04-06 18:16 ` Namhyung Kim [this message]
2026-04-06 18:25 ` Ian Rogers
2026-04-07 5:24 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adP4dyKNTz3LjFmt@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.