All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>,
	kvm@vger.kernel.org,  linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 Paolo Bonzini <pbonzini@redhat.com>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] KVM: selftests: memslot_perf_test: make host wait timeout configurable
Date: Mon, 6 Apr 2026 16:00:12 -0700	[thread overview]
Message-ID: <adQ6_MyjhnpJYJ5H@google.com> (raw)
In-Reply-To: <64d44f37-7d31-46be-b9ed-cc86969777dd@maciej.szmigiero.name>

On Thu, Apr 02, 2026, Maciej S. Szmigiero wrote:
> On 2.04.2026 12:29, Mayuresh Chitale wrote:
> > When memslot_perf_test is run on qemu, sometimes the RW subtest fails
> > due to sigalarm, indicating that the guest sync did not finish within
> > the expected duration of 10 seconds. Since the current timeout value is
> > itself a bump up from the original 2s, making the host timeout value
> > configurable via a new command line parameter. Now the test can be
> > invoked with '-a' argument to run the test with a suitable host timeout
> > value.
> > 
> > Signed-off-by: Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>
> > ---
> 
> Out of curiosity: which KVM-enabled setup takes more than 10 seconds
> to run that RW test?

Hmm, I assume "run on qemu" means running in a VM that's fully emulated by QEMU?
That would probably explain why it's so slow?

> Does it have like, multiple levels of nesting?
> 
> When I wrote that test I calibrated it on a mid-range x86 machine,
> where one iteration took on the order of 0.01 s.
> 
> 10 s time limit per iteration is already three orders of magnitude
> slower than that.
> 
> Otherwise, the patch looks sensible to me.
> 
> Thanks,
> Maciej
> 

  reply	other threads:[~2026-04-06 23:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 10:29 [PATCH] KVM: selftests: memslot_perf_test: make host wait timeout configurable Mayuresh Chitale
2026-04-02 18:20 ` Maciej S. Szmigiero
2026-04-06 23:00   ` Sean Christopherson [this message]
2026-04-07 10:21     ` Mayuresh Chitale
2026-04-07 10:23       ` Maciej S. Szmigiero
2026-04-07 10:18   ` Mayuresh Chitale
2026-04-06 23:01 ` Sean Christopherson
2026-04-07 10:24   ` Mayuresh Chitale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adQ6_MyjhnpJYJ5H@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=mayuresh.chitale@oss.qualcomm.com \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.