Re: [PATCH 1/2] input: pc110pad: change PCI check to get rid of orphaned no_pci_devices

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Mon, Apr 06, 2026 at 12:23:24PM -0500, Bjorn Helgaas wrote:
> On Fri, Apr 03, 2026 at 12:17:35AM +0200, Heiner Kallweit wrote:
> > As a prerequisite for removing no_pci_devices(), replace its usage here
> > with an equivalent check for presence of a PCI bus.
> > 
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> > ---
> >  drivers/input/mouse/pc110pad.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/input/mouse/pc110pad.c b/drivers/input/mouse/pc110pad.c
> > index efa58049f..c7a6df210 100644
> > --- a/drivers/input/mouse/pc110pad.c
> > +++ b/drivers/input/mouse/pc110pad.c
> > @@ -91,7 +91,7 @@ static int __init pc110pad_init(void)
> >  {
> >  	int err;
> >  
> > -	if (!no_pci_devices())
> > +	if (pci_find_next_bus(NULL))
> >  		return -ENODEV;
> 
> I'd certainly love to get rid of no_pci_devices(), although using
> pci_find_next_bus() is not really much better.
> 
> I don't have much opinion about pc110pad.c change.  It's essentially
> still the same kludge, which has been there at least since the
> beginning of git history.
> 
> Dmitry, if you want to ack this, I can take both together.

Given "x86/cpu: Remove M486/M486SX/ELAN support" I'd just drop the
driver completely.

I tried it in 2024 but Maciej was insistent that keeping these old
drivers doe snot hurt. Now I think we can get rid of them.

You can grab the patch removing it from
https://lore.kernel.org/all/20240808172733.1194442-4-dmitry.torokhov@gmail.com/
as I think it should still apply.

Thanks.

-- 
Dmitry