Re: [LTP] [PATCH 04/17] lib: tst_kconfig: Add module presence checks

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> Maybe rename the struct to:
> 
> 	static struct config_module_map {
> 		const char *config;
> 		const char *module_name;
> 	} config_module_maps[] = {
> 		...
> 	}
> 
> And rename 'struct runtime_check' to:
> 
> 	static struct config_runtime_map {
> 		const char *config;
> 		bool (*runtime_check)(void);
> 	} config_runtime_maps[] = {
> 		...
> 	};
> 
> This is a tiny nit; I don't have strong opinions.
> 
> >  static inline int kconfig_parse_line(const char *line,
> >                                       struct tst_kconfig_var *vars,
> >                                       unsigned int vars_len)
> > @@ -222,6 +262,7 @@ out:
> >  			case 'm':
> >  				vars[i].choice = 'm';
> >  				runtime_check(&vars[i]);
> > +				module_check(&vars[i]);
> 
> Then rename the two functions to:
> 
>     kconfig_runtime_check()
>     kconfig_module_check()
> 
> Because in tst_kconfig.c most function contains "kconfig_" string.

I do not have strong opition, if you agree that these names are better
we can rename them.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp