From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Stellman <astellman@stellman-greene.com>
Cc: Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] zram: add init_done() guard to algorithm_params_store()
Date: Tue, 7 Apr 2026 23:14:24 +0900 [thread overview]
Message-ID: <adURE1qZ_4T1eTvZ@google.com> (raw)
In-Reply-To: <20260407123836.6341-5-astellman@stellman-greene.com>
On (26/04/07 08:38), Andrew Stellman wrote:
> @@ -1772,6 +1772,12 @@ static ssize_t algorithm_params_store(struct device *dev,
> if (prio < ZRAM_PRIMARY_COMP || prio >= ZRAM_MAX_COMPS)
> return -EINVAL;
>
> + guard(rwsem_write)(&zram->dev_lock);
> + if (init_done(zram)) {
> + pr_info("Can't change algorithm params for initialized device\n");
> + return -EBUSY;
> + }
> +
> ret = comp_params_store(zram, prio, level, dict_path, &deflate_params);
> return ret ? ret : len;
> }
This is already fixed.
prev parent reply other threads:[~2026-04-07 14:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 12:38 [PATCH 0/4] zram: fix four error-handling and input-validation bugs Andrew Stellman
2026-04-07 12:38 ` [PATCH 1/4] zram: complete parent bio on allocation failure in read_from_bdev_async() Andrew Stellman
2026-04-07 14:15 ` Sergey Senozhatsky
2026-04-07 12:38 ` [PATCH 2/4] zram: call bio_endio() on early return in zram_bio_discard() Andrew Stellman
2026-04-07 14:14 ` Sergey Senozhatsky
2026-04-07 12:38 ` [PATCH 3/4] zram: reject unrecognized type= values in recompress_store() Andrew Stellman
2026-04-07 14:18 ` Sergey Senozhatsky
2026-04-07 12:38 ` [PATCH 4/4] zram: add init_done() guard to algorithm_params_store() Andrew Stellman
2026-04-07 14:14 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adURE1qZ_4T1eTvZ@google.com \
--to=senozhatsky@chromium.org \
--cc=astellman@stellman-greene.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.