From: Gregory Price <gourry@gourry.net>
To: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jackie Liu <liu.yun@linux.dev>,
David Hildenbrand <david@kernel.org>, Zi Yan <ziy@nvidia.com>,
Matthew Brost <matthew.brost@intel.com>,
Rakie Kim <rakie.kim@sk.com>, Byungchul Park <byungchul@sk.com>,
Ying Huang <ying.huang@linux.alibaba.com>,
Alistair Popple <apopple@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH] mm/mempolicy: Fix weighted interleave auto sysfs name
Date: Tue, 7 Apr 2026 13:33:43 -0400 [thread overview]
Message-ID: <adU_9_J74OO9bUhz@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <20260407172350.699577-1-joshua.hahnjy@gmail.com>
On Tue, Apr 07, 2026 at 10:23:50AM -0700, Joshua Hahn wrote:
> On Tue, 7 Apr 2026 13:09:04 -0400 Gregory Price <gourry@gourry.net> wrote:
>
> > > Signed-off-by: Joshua Hahn <joshua.hahnjy@gmail.com>
> >
> > Maybe -
> >
> > Fixes: 2fb6915fa22d ("compiler_types.h: add "auto" as a macro for "__auto_type"")
>
> I thought about adding a Fixes tag, decided against it because it's
> purely cosmetic.
>
> ... but now that I think about it, I think this could break some workflows
> for users who have automated writing to the auto sysfs file.
>
Yes, it broke userland software depending on that symbol being there
(which, hopefully, is very little at this point in time).
> Maybe I should add a fixes tag for the patch that introduced the
> sysfs file instead? That is,
>
> Fixes: e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning")
>
The original commit introduced 'auto' and the compiler_types.h commit
modified that to "__auto_type". The latter broke userland so that's the
right commit to mark for Fixes.
~Gregory
next prev parent reply other threads:[~2026-04-07 17:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:14 [PATCH] mm/mempolicy: Fix weighted interleave auto sysfs name Joshua Hahn
2026-04-07 17:09 ` Gregory Price
2026-04-07 17:23 ` Joshua Hahn
2026-04-07 17:33 ` Gregory Price [this message]
2026-04-09 7:05 ` Huang, Ying
2026-04-08 4:56 ` Rakie Kim
2026-04-08 8:04 ` David Hildenbrand (Arm)
2026-04-08 18:05 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adU_9_J74OO9bUhz@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=byungchul@sk.com \
--cc=david@kernel.org \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liu.yun@linux.dev \
--cc=matthew.brost@intel.com \
--cc=rakie.kim@sk.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.