Re: [PATCH 0/3] drm/i915: relocate mchbar and pci regs headers

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Apr 07, 2026 at 01:57:39PM +0300, Jani Nikula wrote:
> Move the MCHBAR and PCI regs headers under include/drm/intel.
> 
> Jani Nikula (3):
>   drm/i915/mchbar: include intel_mchbar_regs.h from intel_mchbar.h
>   drm/i915/mchbar: move intel_mchbar_regs.h under include/drm/intel
>   drm/i915/pci: move intel_pci_config.h under include/drm/intel

Spotted a few places that could drop the include entirely. Otherwise
looks fine.

Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
>  drivers/gpu/drm/i915/display/i9xx_display_sr.c              | 2 +-
>  drivers/gpu/drm/i915/display/i9xx_wm.c                      | 1 -
>  drivers/gpu/drm/i915/display/intel_backlight.c              | 2 +-
>  drivers/gpu/drm/i915/display/intel_bw.c                     | 1 -
>  drivers/gpu/drm/i915/display/intel_cdclk.c                  | 3 +--
>  drivers/gpu/drm/i915/display/intel_display_power.c          | 1 -
>  drivers/gpu/drm/i915/display/intel_dram.c                   | 1 -
>  drivers/gpu/drm/i915/display/intel_lpe_audio.c              | 2 +-
>  drivers/gpu/drm/i915/display/intel_mchbar.c                 | 1 -
>  drivers/gpu/drm/i915/display/intel_mchbar.h                 | 2 ++
>  drivers/gpu/drm/i915/display/intel_opregion.c               | 2 +-
>  drivers/gpu/drm/i915/gem/i915_gem_stolen.c                  | 4 ++--
>  drivers/gpu/drm/i915/gt/intel_ggtt.c                        | 2 +-
>  drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c                | 2 +-
>  drivers/gpu/drm/i915/gt/intel_gt.c                          | 2 +-
>  drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c               | 2 +-
>  drivers/gpu/drm/i915/gt/intel_llc.c                         | 2 +-
>  drivers/gpu/drm/i915/gt/intel_region_lmem.c                 | 2 +-
>  drivers/gpu/drm/i915/gt/intel_reset.c                       | 5 +++--
>  drivers/gpu/drm/i915/gt/intel_rps.c                         | 4 ++--
>  drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c                 | 2 +-
>  drivers/gpu/drm/i915/gvt/cfg_space.c                        | 2 +-
>  drivers/gpu/drm/i915/gvt/handlers.c                         | 4 ++--
>  drivers/gpu/drm/i915/i915_debugfs.c                         | 2 +-
>  drivers/gpu/drm/i915/i915_driver.c                          | 2 +-
>  drivers/gpu/drm/i915/i915_freq.c                            | 2 +-
>  drivers/gpu/drm/i915/i915_gmch.c                            | 2 +-
>  drivers/gpu/drm/i915/i915_hwmon.c                           | 2 +-
>  drivers/gpu/drm/i915/i915_overlay.c                         | 2 +-
>  drivers/gpu/drm/i915/i915_pci.c                             | 2 +-
>  drivers/gpu/drm/i915/intel_clock_gating.c                   | 4 ++--
>  drivers/gpu/drm/i915/intel_gvt_mmio_table.c                 | 2 +-
>  drivers/gpu/drm/xe/compat-i915-headers/intel_mchbar_regs.h  | 6 ------
>  drivers/gpu/drm/xe/compat-i915-headers/intel_pci_config.h   | 6 ------
>  .../intel_mchbar_regs.h => include/drm/intel/mchbar_regs.h  | 0
>  .../intel_pci_config.h => include/drm/intel/pci_config.h    | 0
>  36 files changed, 34 insertions(+), 49 deletions(-)
>  delete mode 100644 drivers/gpu/drm/xe/compat-i915-headers/intel_mchbar_regs.h
>  delete mode 100644 drivers/gpu/drm/xe/compat-i915-headers/intel_pci_config.h
>  rename drivers/gpu/drm/i915/intel_mchbar_regs.h => include/drm/intel/mchbar_regs.h (100%)
>  rename drivers/gpu/drm/i915/intel_pci_config.h => include/drm/intel/pci_config.h (100%)
> 
> -- 
> 2.47.3

-- 
Ville Syrjälä
Intel