All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2 2/5] drm/i915/mchbar: drop unnecessary intel_mchbar_regs.h include
Date: Tue, 7 Apr 2026 23:37:20 +0300	[thread overview]
Message-ID: <adVrAOdCQQvDIZgk@intel.com> (raw)
In-Reply-To: <7eaf98e648240e3011bfb85d0330787074c39205.1775590536.git.jani.nikula@intel.com>

On Tue, Apr 07, 2026 at 10:36:27PM +0300, Jani Nikula wrote:
> There are some unnecessary includes. Remove.
> 
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 1 -
>  drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c   | 1 -
>  drivers/gpu/drm/i915/gvt/handlers.c           | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> index babaf16e72f2..adf2512e2ed5 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> @@ -19,7 +19,6 @@
>  #include "intel_gt_pm_debugfs.h"
>  #include "intel_gt_regs.h"
>  #include "intel_llc.h"
> -#include "intel_mchbar_regs.h"
>  #include "intel_pcode.h"
>  #include "intel_rc6.h"
>  #include "intel_rps.h"
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> index fa9af08f9708..a75f05ff1110 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> @@ -16,7 +16,6 @@
>  #include "i915_wait_util.h"
>  #include "intel_guc_print.h"
>  #include "intel_guc_slpc.h"
> -#include "intel_mchbar_regs.h"
>  
>  /**
>   * DOC: SLPC - Dynamic Frequency management
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index a34f56630af9..9f61867e2478 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -71,7 +71,6 @@
>  #include "i915_drv.h"
>  #include "i915_pvinfo.h"
>  #include "i915_reg.h"
> -#include "intel_mchbar_regs.h"
>  #include "sched_policy.h"
>  
>  /* XXX FIXME i915 has changed PP_XXX definition */
> -- 
> 2.47.3

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2026-04-07 20:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07 19:36 [PATCH v2 0/5] drm/i915: relocate mchbar and pci regs headers Jani Nikula
2026-04-07 19:36 ` [PATCH v2 1/5] drm/i915/mchbar: include intel_mchbar_regs.h from intel_mchbar.h Jani Nikula
2026-04-07 19:36 ` [PATCH v2 2/5] drm/i915/mchbar: drop unnecessary intel_mchbar_regs.h include Jani Nikula
2026-04-07 20:37   ` Ville Syrjälä [this message]
2026-04-07 19:36 ` [PATCH v2 3/5] drm/i915/mchbar: move intel_mchbar_regs.h under include/drm/intel Jani Nikula
2026-04-07 19:36 ` [PATCH v2 4/5] drm/i915: drop unnecessary intel_pci_config.h include Jani Nikula
2026-04-07 20:37   ` Ville Syrjälä
2026-04-07 19:36 ` [PATCH v2 5/5] drm/i915/pci: move intel_pci_config.h under include/drm/intel Jani Nikula
2026-04-07 20:53 ` ✗ CI.checkpatch: warning for drm/i915: relocate mchbar and pci regs headers (rev2) Patchwork
2026-04-07 20:54 ` ✓ CI.KUnit: success " Patchwork
2026-04-07 21:43 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-07 23:39 ` ✓ i915.CI.BAT: " Patchwork
2026-04-08  1:03 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-08  8:20 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adVrAOdCQQvDIZgk@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.