From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Matthew Penney <matt@matthewpenney.net>
Cc: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Joel Stanley" <joel@jms.id.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Samuel Tardieu" <sam@rfc1149.net>,
"Cornelia Huck" <cohuck@redhat.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Collin L. Walling" <walling@linux.ibm.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Amit Shah" <amit@kernel.org>,
qemu-arm@nongnu.org, qemu-s390x@nongnu.org,
"Jason Wang" <jasowang@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
qemu-block@nongnu.org, "Marcelo Tosatti" <mtosatti@redhat.com>,
kvm@vger.kernel.org, "Zhao Liu" <zhao1.liu@intel.com>
Subject: Re: [PATCH 0/8] tree-wide: use g_clear_handle_id() for GSource cleanup
Date: Wed, 8 Apr 2026 09:40:18 +0100 [thread overview]
Message-ID: <adYUcqM4py9e_Q-B@redhat.com> (raw)
In-Reply-To: <20260408010026.4611-1-matt@matthewpenney.net>
On Wed, Apr 08, 2026 at 01:01:42AM +0000, Matthew Penney wrote:
> This series replaces open-coded uses of g_source_remove() with
> g_clear_handle_id() across the tree.
>
> This is a more modern (GLib >= 2.56) approach than directly calling
> g_source_remove().
>
> g_clear_handle_id() simplifies cleanup of GSource IDs since it
> checks the ID is valid, calls the cleanup function and zeros the ID.
>
> This reduces boilerplate and avoids open-coded calls to
> g_source_remove().
>
> This series follows an earlier fix that removed a dangling GSource tag
> and replaced an explicit call to g_source_remove() with
> g_clear_handle_id().
>
> No functional changes.
>
> Link: https://gitlab.com/qemu-project/qemu/-/commit/34aad589019c8687fb3b19ba79d64d97071a7205
Looking at your git repo fork, while the commits are creditted under
your name, all the activity on the repo appears to have done by a bot
account:
https://gitlab.com/mj-penney/qemu/activity
What's the situation here with authorship ?
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-04-08 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 1:01 [PATCH 0/8] tree-wide: use g_clear_handle_id() for GSource cleanup Matthew Penney
2026-04-08 8:40 ` Daniel P. Berrangé [this message]
2026-04-08 10:12 ` Matthew Penney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adYUcqM4py9e_Q-B@redhat.com \
--to=berrange@redhat.com \
--cc=amit@kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=joel@jms.id.au \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=matt@matthewpenney.net \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=sam@rfc1149.net \
--cc=sgarzare@redhat.com \
--cc=walling@linux.ibm.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.