From: John Levon <john.levon@nutanix.com>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: qemu-devel@nongnu.org, Alex Williamson <alex@shazbot.org>,
Thanos Makatos <thanos.makatos@nutanix.com>
Subject: Re: [PATCH 1/2] vfio-user: support VFIO_USER_DEVICE_FEATURE
Date: Wed, 8 Apr 2026 10:00:06 +0100 [thread overview]
Message-ID: <adYZFs0ef-KiRgOE@lent> (raw)
In-Reply-To: <7493bf1e-7e85-454c-9a17-55febee66e58@redhat.com>
On Wed, Apr 08, 2026 at 09:42:30AM +0200, Cédric Le Goater wrote:
> > + if (msgp->hdr.flags & VFIO_USER_ERROR) {
> > + /*
> > + * Client expects ENOTTY for "not supported", but the protocol may
> > + * return EINVAL.
> > + */
>
> Is this errno tanslation due to the call in vfio_region_create_dma_buf() ?
Yes.
> EINVAL could indicate other issues. Is is safe to mask it ?
Yes - this should only occur otherwise in the case of incorrect protocol
messages (i.e. qemu bugs).
regards
john
next prev parent reply other threads:[~2026-04-08 19:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 19:53 [PATCH 0/2] vfio: Implement device features for vfio-user John Levon
2026-03-17 19:53 ` [PATCH 1/2] vfio-user: support VFIO_USER_DEVICE_FEATURE John Levon
2026-04-08 7:42 ` Cédric Le Goater
2026-04-08 9:00 ` John Levon [this message]
2026-03-17 19:53 ` [PATCH 2/2] vfio: quieten dma-buf warning John Levon
2026-04-08 7:52 ` Cédric Le Goater
2026-04-08 8:57 ` John Levon
2026-04-09 9:53 ` Cédric Le Goater
2026-04-09 10:05 ` John Levon
2026-04-09 10:12 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adYZFs0ef-KiRgOE@lent \
--to=john.levon@nutanix.com \
--cc=alex@shazbot.org \
--cc=clg@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thanos.makatos@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.