From: Jarkko Sakkinen <jarkko@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: David Howells <dhowells@redhat.com>, Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] KEYS: annotate struct user_key_payload with __counted_by
Date: Wed, 8 Apr 2026 12:02:25 +0300 [thread overview]
Message-ID: <adYZoWK_CTv2-RA_@kernel.org> (raw)
In-Reply-To: <20260406175810.1018681-4-thorsten.blum@linux.dev>
On Mon, Apr 06, 2026 at 07:58:10PM +0200, Thorsten Blum wrote:
> Add the __counted_by() compiler attribute to the flexible array member
> 'data' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> include/keys/user-type.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/keys/user-type.h b/include/keys/user-type.h
> index 386c31432789..2305991f4fcd 100644
> --- a/include/keys/user-type.h
> +++ b/include/keys/user-type.h
> @@ -27,7 +27,8 @@
> struct user_key_payload {
> struct rcu_head rcu; /* RCU destructor */
> unsigned short datalen; /* length of this data */
> - char data[] __aligned(__alignof__(u64)); /* actual data */
> + char data[] /* actual data */
> + __aligned(__alignof__(u64)) __counted_by(datalen);
> };
>
> extern struct key_type key_type_user;
You don't provide any evidence of any improvement.
BR, Jarkko
next prev parent reply other threads:[~2026-04-08 9:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 17:58 [PATCH net-next 1/2] keys, dns: drop unused upayload->data NUL terminator Thorsten Blum
2026-04-06 17:58 ` [PATCH net-next 2/2] KEYS: annotate struct user_key_payload with __counted_by Thorsten Blum
2026-04-08 9:02 ` Jarkko Sakkinen [this message]
2026-04-08 12:21 ` Thorsten Blum
2026-04-14 23:58 ` Jarkko Sakkinen
2026-04-15 9:40 ` Thorsten Blum
2026-04-15 12:08 ` Jarkko Sakkinen
2026-04-16 10:13 ` Thorsten Blum
2026-04-19 12:06 ` Jarkko Sakkinen
2026-04-19 12:09 ` Jarkko Sakkinen
2026-04-09 2:39 ` [PATCH net-next 1/2] keys, dns: drop unused upayload->data NUL terminator Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adYZoWK_CTv2-RA_@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.