From: Kevin Wolf <kwolf@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
peter.maydell@linaro.org, pbonzini@redhat.com
Subject: Re: [PULL 4/6] monitor: Fix deadlock in monitor_cleanup
Date: Wed, 8 Apr 2026 11:05:23 +0200 [thread overview]
Message-ID: <adYaUz0JtcrzY3L1@redhat.com> (raw)
In-Reply-To: <bec7c78b-26fe-42d2-b274-0e6ef6b9b394@tls.msk.ru>
Am 07.04.2026 um 19:12 hat Michael Tokarev geschrieben:
> On 07.04.2026 19:46, Kevin Wolf wrote:
> > Am 07.04.2026 um 15:30 hat Michael Tokarev geschrieben:
>
> > > I *guess* qapi/qmp-dispatch.c should not be used by qga. That to say, -
> > > instead of adding more stuff to qga link line, it looks like we should
> > > remove stuff from it :)
> >
> > I don't think you can have QMP without qapi/qmp-dispatch.c, so this does
> > look like the right fix to me. There is no real reason why aio-wait.c
> > should be considered specific to the block layer.
>
> Well, or at least, qga can provide stub for aio_wait_kick().
As far as I can tell, qga has the same monitor setup as qemu, i.e. there
is qemu_aio_context as the default, iohandler_ctx where the monitor I/O
is processed and a monitor iothread.
This means that you need the real aio_wait_kick(), not just a stub, to
avoid deadlocks.
Kevin
next prev parent reply other threads:[~2026-04-08 19:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 15:03 [PULL 0/6] Block layer patches Kevin Wolf
2026-03-31 15:03 ` [PULL 1/6] ide: Fix potential assertion failure on VM stop for PIO read error Kevin Wolf
2026-03-31 15:03 ` [PULL 2/6] scsi: Don't consider LOGICAL UNIT NOT SUPPORTED guest recoverable Kevin Wolf
2026-03-31 15:03 ` [PULL 3/6] block: Fix references in bdrv_bsc_*() function comments Kevin Wolf
2026-03-31 15:03 ` [PULL 4/6] monitor: Fix deadlock in monitor_cleanup Kevin Wolf
2026-04-04 6:02 ` Michael Tokarev
2026-04-04 6:08 ` Michael Tokarev
2026-04-07 12:04 ` Kevin Wolf
2026-04-07 13:30 ` Michael Tokarev
2026-04-07 16:46 ` Kevin Wolf
2026-04-07 17:12 ` Michael Tokarev
2026-04-08 9:05 ` Kevin Wolf [this message]
2026-04-07 16:57 ` Michael Tokarev
2026-03-31 15:03 ` [PULL 5/6] vhost-user-blk-server: fix opt_io_size=1 causing severe Windows I/O degradation Kevin Wolf
2026-03-31 15:03 ` [PULL 6/6] block: Fix crash after setting latency historygram with single bin Kevin Wolf
2026-03-31 18:04 ` [PULL 0/6] Block layer patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adYaUz0JtcrzY3L1@redhat.com \
--to=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.