All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Shuming [范書銘]" <shumingf@realtek.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"Flove(HsinFu)" <flove@realtek.com>,
	"Oder Chiou" <oder_chiou@realtek.com>,
	"Jack Yu" <jack.yu@realtek.com>,
	"Derek [方德義]" <derek.fang@realtek.com>
Subject: Re: [PATCH] ASoC: SDCA: restore the settings if power is lost during suspend
Date: Wed, 8 Apr 2026 10:43:42 +0100	[thread overview]
Message-ID: <adYjTi4tQDAlYu+7@opensource.cirrus.com> (raw)
In-Reply-To: <0f4584c21f1943a18c2e25295daab931@realtek.com>

On Wed, Apr 08, 2026 at 09:40:15AM +0000, Shuming [范書銘] wrote:
> > On Wed, Apr 08, 2026 at 04:56:07PM +0800, shumingf@realtek.com wrote:
> > > From: Shuming Fan <shumingf@realtek.com>
> > >
> > > We should restore the MIPI-defined registers when the device is attached.
> > > If a function status interrupt occurs, the device will trigger an interrupt to
> > reload the settings.
> > >
> > 
> > Are you actually hitting this in practice? What is the situation where the device
> > loses power but it isn't covered by the normal suspend/resume flow?
> 
> This is a scenario where the machine enters hibernation and cuts power to the codec.
> I simulated this case and verified that it works as expected.
> 

But in that case the suspend/resume callback should be called and
the cache should be synchronised on that path. Are you not seeing
those run?

Thanks,
Charles

  reply	other threads:[~2026-04-08  9:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08  8:56 [PATCH] ASoC: SDCA: restore the settings if power is lost during suspend shumingf
2026-04-08  9:21 ` Charles Keepax
2026-04-08  9:40   ` Shuming [范書銘]
2026-04-08  9:43     ` Charles Keepax [this message]
2026-04-08  9:58     ` Richard Fitzgerald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adYjTi4tQDAlYu+7@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=derek.fang@realtek.com \
    --cc=flove@realtek.com \
    --cc=jack.yu@realtek.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=shumingf@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.