From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Cc: Linux RDMA list
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
ewg <ewg-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org>
Subject: Re: [ewg] [PATCHv8 02/11] ib_core: IBoE support only QP1
Date: Wed, 05 May 2010 16:12:15 -0700 [thread overview]
Message-ID: <ada1vdqaqpc.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <20100218172344.GC12286@mtls03> (Eli Cohen's message of "Thu, 18 Feb 2010 19:23:44 +0200")
> @@ -795,11 +799,12 @@ static void mcast_add_one(struct ib_device *device)
> struct mcast_device *dev;
> struct mcast_port *port;
> int i;
> + int count = 0;
>
> if (rdma_node_get_transport(device->node_type) != RDMA_TRANSPORT_IB)
> return;
>
> - dev = kmalloc(sizeof *dev + device->phys_port_cnt * sizeof *port,
> + dev = kzalloc(sizeof *dev + device->phys_port_cnt * sizeof *port,
> @@ -1007,7 +1010,7 @@ static void ib_sa_add_one(struct ib_device *device)
> e = device->phys_port_cnt;
> }
>
> - sa_dev = kmalloc(sizeof *sa_dev +
> + sa_dev = kzalloc(sizeof *sa_dev +
Do you happen to remember why you needed these kmalloc -> kzalloc conversions?
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-05-05 23:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 17:23 [PATCHv8 02/11] ib_core: IBoE support only QP1 Eli Cohen
2010-05-05 23:12 ` Roland Dreier [this message]
[not found] ` <ada1vdqaqpc.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-05-06 14:28 ` [ewg] " Eli Cohen
[not found] ` <20100506142849.GC29792-8YAHvHwT2UEvbXDkjdHOrw/a8Rv0c6iv@public.gmane.org>
2010-05-16 5:17 ` Or Gerlitz
2010-05-12 19:56 ` Roland Dreier
[not found] ` <ada632svqph.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-05-13 6:59 ` Eli Cohen
[not found] ` <20100513065917.GA16073-8YAHvHwT2UEvbXDkjdHOrw/a8Rv0c6iv@public.gmane.org>
2010-05-13 15:48 ` Roland Dreier
[not found] ` <adatyqbsszt.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-05-13 16:52 ` Eli Cohen
[not found] ` <20100513165201.GA19438-8YAHvHwT2UEvbXDkjdHOrw/a8Rv0c6iv@public.gmane.org>
2010-05-13 17:35 ` Roland Dreier
[not found] ` <adahbmbso19.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-05-17 11:59 ` Eli Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada1vdqaqpc.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=ewg-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.