From: Roland Dreier <rdreier@cisco.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [PATCH 1/1] introduce __cancel_delayed_work()
Date: Tue, 01 Sep 2009 09:09:36 -0700 [thread overview]
Message-ID: <ada1vmqpry7.fsf@cisco.com> (raw)
In-Reply-To: <20090828180015.GB19326@redhat.com> (Oleg Nesterov's message of "Fri, 28 Aug 2009 20:00:15 +0200")
> cancel_delayed_work() has to use del_timer_sync() to guarantee the
> timer function is not running after return. But most users doesn't
> actually need this, and del_timer_sync() has problems: it is not
> useable from interrupt, and it depends on every lock which could
> be taken from irq.
>
> Introduce __cancel_delayed_work() which calls del_timer() instead.
>
> The immediate reason for this patch is
> http://bugzilla.kernel.org/show_bug.cgi?id=13757
> but hopefully this helper makes sense anyway.
Thanks, Oleg!
Andrew -- how do you want to handle this? This seems to be useful for
the bug with IB that Oleg linked to, as well as by Dmitry in input, so
I'm not sure what the best way to merge all this into 2.6.32 is.
I could take Oleg's patch and the corresponding fix to
drivers/infiniband through my tree, and merge as early I as I see Linus
open 2.6.32. That leaves Dmitry to wait on it (and possibly causes
problems in -next with tree ordering) though. But I don't see any way
to get the number of cross-tree dependencies below 1... (unless maybe
Dmitry can take the identical workqueue patch into his tree and trust
git to sort it out?)
- R.
next prev parent reply other threads:[~2009-09-01 16:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 21:51 Is adding requeue_delayed_work() a good idea Roland Dreier
2009-08-21 11:55 ` Oleg Nesterov
2009-08-21 21:53 ` Roland Dreier
2009-08-22 10:35 ` Stefan Richter
2009-08-24 18:01 ` Oleg Nesterov
2009-08-24 21:11 ` Roland Dreier
2009-08-25 9:39 ` Oleg Nesterov
2009-08-26 18:42 ` Roland Dreier
2009-08-28 17:59 ` [PATCH 0/1] introduce __cancel_delayed_work() Oleg Nesterov
2009-08-28 18:00 ` [PATCH 1/1] " Oleg Nesterov
2009-09-01 16:09 ` Roland Dreier [this message]
2009-09-01 16:40 ` Dmitry Torokhov
2009-09-01 22:29 ` Andrew Morton
2009-09-01 0:44 ` Is adding requeue_delayed_work() a good idea Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada1vmqpry7.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.