From: Roland Dreier <rdreier@cisco.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iWARP Connection Manager.
Date: Wed, 31 May 2006 12:24:42 -0700 [thread overview]
Message-ID: <ada3beqyp39.fsf@cisco.com> (raw)
In-Reply-To: <20060531114059.704ef1f1@localhost.localdomain> (Stephen Hemminger's message of "Wed, 31 May 2006 11:40:59 -0700")
> > + cm_id_priv = kzalloc(sizeof *cm_id_priv, GFP_KERNEL);
> Please put paren's after sizeof, it is not required by C but it
> is easier to read.
I disagree -- I hate seeing sizeof look like a function call.
- R.
next prev parent reply other threads:[~2006-05-31 19:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-31 18:26 [PATCH 0/2][RFC] iWARP Core Support Steve Wise
2006-05-31 18:26 ` [PATCH 1/2] iWARP Connection Manager Steve Wise
2006-05-31 18:40 ` Stephen Hemminger
2006-05-31 19:24 ` Roland Dreier [this message]
2006-05-31 20:47 ` Muli Ben-Yehuda
2006-05-31 20:58 ` Steve Wise
2006-05-31 21:01 ` Stephen Hemminger
2006-05-31 21:54 ` Roland Dreier
2006-05-31 22:22 ` Steve Wise
2006-05-31 22:22 ` Sean Hefty
2006-06-01 17:00 ` Steve Wise
2006-06-01 21:09 ` Sean Hefty
2006-06-01 22:21 ` [openib-general] " Tom Tucker
2006-06-01 17:11 ` Tom Tucker
2006-05-31 18:26 ` [PATCH 2/2] iWARP Core Changes Steve Wise
2006-05-31 18:36 ` Stephen Hemminger
2006-05-31 19:17 ` Roland Dreier
2006-05-31 20:30 ` Steve Wise
2006-05-31 20:32 ` Roland Dreier
2006-05-31 21:26 ` Sean Hefty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada3beqyp39.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.