From: Roland Dreier <rdreier@cisco.com>
To: Andrew Morton <akpm@osdl.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, openib-general@openib.org
Subject: Re: [PATCH] net: Move destructor from neigh->ops to neigh_params
Date: Mon, 06 Mar 2006 21:50:30 -0800 [thread overview]
Message-ID: <ada3bhu247t.fsf@cisco.com> (raw)
In-Reply-To: <20060306211630.0df79464.akpm@osdl.org> (Andrew Morton's message of "Mon, 6 Mar 2006 21:16:30 -0800")
Andrew> I'm also wondering why a combination of the net and
Andrew> infiniband trees does this:
Andrew> drivers/infiniband/ulp/ipoib/ipoib_multicast.c: In
Andrew> function `ipoib_mcast_free':
Andrew> drivers/infiniband/ulp/ipoib/ipoib_multicast.c:118: error:
Andrew> structure has no member named `destructor'
A cock-up on my part. I think I fixed this when testing the patch,
and promptly forgot about doing it. Then when I reposted the patch to
netdev, I decided to be very careful about things, so I went back to
pristine sources from Michael's message, which of course is missing
the following chunk:
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
index fde442a..93c462e 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
@@ -115,7 +115,6 @@ static void ipoib_mcast_free(struct ipoi
if (neigh->ah)
ipoib_put_ah(neigh->ah);
*to_ipoib_neigh(neigh->neighbour) = NULL;
- neigh->neighbour->ops->destructor = NULL;
kfree(neigh);
}
next prev parent reply other threads:[~2006-03-07 5:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-23 21:27 [PATCH] net: Move destructor from neigh->ops to neigh_params Roland Dreier
2006-01-23 21:54 ` David S. Miller
2006-02-02 1:28 ` [PATCH RESEND] " Roland Dreier
2006-02-02 1:31 ` David S. Miller
2006-02-02 1:33 ` Roland Dreier
2006-02-02 1:34 ` YOSHIFUJI Hideaki / 吉藤英明
2006-02-21 3:42 ` Roland Dreier
2006-02-21 4:01 ` David S. Miller
2006-02-21 4:48 ` Roland Dreier
2006-02-21 4:55 ` David S. Miller
2006-03-04 1:58 ` David S. Miller
2006-03-07 5:16 ` [PATCH] " Andrew Morton
2006-03-07 5:40 ` Shirley Ma
2006-03-07 5:44 ` Roland Dreier
2006-03-07 6:11 ` David S. Miller
2006-03-07 5:50 ` Roland Dreier [this message]
2006-03-07 19:21 ` [PATCH] IPoIB: Fix build now that destructor is in neigh_params Roland Dreier
2006-03-07 22:53 ` David S. Miller
2006-03-07 22:56 ` Roland Dreier
2006-03-07 19:22 ` [PATCH] [NET]: Move destructor from neigh->ops to neigh_params Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada3bhu247t.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.