From: Roland Dreier <rdreier@cisco.com>
To: Jesse Barnes <jesse.barnes@intel.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Matthew Wilcox <matthew@wil.cx>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"general\@lists.openfabrics.org" <general@lists.openfabrics.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: mthca double free irqs
Date: Fri, 12 Jun 2009 09:25:36 -0700 [thread overview]
Message-ID: <ada4oul1ksf.fsf@cisco.com> (raw)
In-Reply-To: <20090612085053.0fbe9731@jbarnes-g45> (Jesse Barnes's message of "Fri, 12 Jun 2009 08:50:53 -0700")
> My linux-next branch has a change to the return value from the MSI-X
> allocation function: pci_enable_msix now returns the number of
> available entries rather than -EINVAL if the allocation failed. Would
> that cause problems in the mthca driver?
I don't think so in this case ... the driver is getting past enabling
MSI-X and actually testing the interrupt before it fails. I'll audit
the code just to make sure we handle that case though. But I thought
pci_enable_msix() always returned the number of entries actually
available if the allocation failed?
- R.
next prev parent reply other threads:[~2009-06-12 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 2:45 mthca double free irqs Yinghai Lu
2009-06-12 14:31 ` Roland Dreier
2009-06-12 17:22 ` Yinghai Lu
2009-06-12 14:33 ` Roland Dreier
2009-06-12 15:50 ` Jesse Barnes
2009-06-12 16:25 ` Roland Dreier [this message]
2009-06-12 16:26 ` Roland Dreier
2009-06-13 4:30 ` Roland Dreier
2009-06-13 19:28 ` Yinghai Lu
2009-06-13 22:04 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada4oul1ksf.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=general@lists.openfabrics.org \
--cc=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.