From: Roland Dreier <rdreier@cisco.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
iss_storagedev@hp.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH cciss: fix printk format warning
Date: Thu, 26 Oct 2006 16:19:56 -0700 [thread overview]
Message-ID: <ada64e67jhf.fsf@cisco.com> (raw)
In-Reply-To: <20061026160245.26f86ce2.akpm@osdl.org> (Andrew Morton's message of "Thu, 26 Oct 2006 16:02:45 -0700")
> > if (*total_size != (__u32) 0)
>
> Why is cciss_read_capacity casting *total_size to u32?
It's not -- it's actually casting 0 to __32 -- there's no cast on the
*total_size side of the comparison. However that just makes the cast
look even fishier.
- R.
next prev parent reply other threads:[~2006-10-26 23:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 4:46 [PATCH cciss: fix printk format warning Randy Dunlap
2006-10-24 13:25 ` Miller, Mike (OS Dev)
2006-10-26 23:02 ` Andrew Morton
2006-10-26 23:19 ` Roland Dreier [this message]
2006-10-26 23:29 ` Randy Dunlap
2006-10-26 23:35 ` Randy Dunlap
2006-10-26 23:49 ` Roland Dreier
2006-10-26 23:53 ` Randy Dunlap
2006-10-27 13:11 ` Cameron, Steve
2006-10-27 15:07 ` Randy Dunlap
2006-10-27 15:15 ` Miller, Mike (OS Dev)
2006-10-26 23:31 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada64e67jhf.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@osdl.org \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.