All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Jack Morgenstein <jackm@dev.mellanox.co.il>
Cc: general@lists.openfabrics.org,
	Marcin Slusarz <marcin.slusarz@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [ofa-general] Re: [PATCH 10/14] infiniband: use printk_once
Date: Mon, 10 Aug 2009 10:42:18 -0700	[thread overview]
Message-ID: <ada7hxba7lx.fsf@cisco.com> (raw)
In-Reply-To: <200908100936.26963.jackm@dev.mellanox.co.il> (Jack Morgenstein's message of "Mon, 10 Aug 2009 09:36:26 +0300")


 > I'm a bit nervous about this one.  
 > printk_once will print once ONLY if CONFIG_PRINTK is set in include/linux/autoconf.h
 > (i.e., when the kernel is configured).  Otherwise, it gets defined to printk --
 > and it will always print in this case.
 > (see 2.6.30.xx kernel include file "include/linux/kernel.h", lines 235, 249, and 272).

Umm... if CONFIG_PRINTK is turned off nothing prints, right?

 > Do you think that distributions will ALWAYS have CONFIG_PRINTK defined?

Yes, I suspect they do want to get kernel messages.

 - R.

  parent reply	other threads:[~2009-08-10 17:42 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-09 19:53 [PATCH 00/14] use printk_once Marcin Slusarz
2009-08-09 19:53 ` [PATCH 01/14] alpha: " Marcin Slusarz
2009-08-09 19:53 ` [PATCH 02/14] ia64: " Marcin Slusarz
2009-08-09 19:53   ` Marcin Slusarz
2009-08-09 19:53 ` [PATCH 03/14] powerpc: " Marcin Slusarz
2009-08-09 19:53   ` Marcin Slusarz
2009-08-10  8:00   ` Wolfram Sang
2009-08-10  8:00     ` Wolfram Sang
2009-08-10 11:46     ` Michael Ellerman
2009-08-10 11:46       ` Michael Ellerman
2009-08-10 11:56       ` Gary Thomas
2009-08-10 11:56         ` Gary Thomas
2009-08-09 19:53 ` [PATCH 04/14] sh: " Marcin Slusarz
2009-08-09 19:53   ` Marcin Slusarz
2009-08-13  3:04   ` Paul Mundt
2009-08-13  3:04     ` Paul Mundt
2009-08-09 19:54 ` [PATCH 05/14] x86: " Marcin Slusarz
2009-08-09 20:30   ` [tip:x86/cleanups] x86: Use printk_once() tip-bot for Marcin Slusarz
2009-08-09 19:54 ` [PATCH 06/14] ata: use printk_once Marcin Slusarz
2009-08-09 19:54 ` [PATCH 07/14] block: " Marcin Slusarz
2009-08-09 19:54 ` [PATCH 08/14] tty/vt: " Marcin Slusarz
2009-08-09 19:54 ` [PATCH 09/14] ide: " Marcin Slusarz
2009-08-10  2:52   ` David Miller
2009-08-09 19:54 ` [PATCH 10/14] infiniband: " Marcin Slusarz
2009-08-10  5:00   ` Roland Dreier
2009-08-10  6:36     ` [ofa-general] " Jack Morgenstein
2009-08-10  7:36       ` Jiri Slaby
2009-08-10 17:42       ` Roland Dreier [this message]
2009-08-11  7:17         ` Jack Morgenstein
2009-08-10 16:07     ` Marcin Slusarz
2009-08-11 16:40       ` Roland Dreier
2009-08-09 19:54 ` [PATCH 11/14] drivers/net: " Marcin Slusarz
2009-08-10  2:52   ` David Miller
2009-08-09 19:54 ` [PATCH 12/14] scsi: " Marcin Slusarz
2009-08-11 16:40   ` James Bottomley
2009-08-11 16:46     ` Roland Dreier
2009-08-11 16:50       ` James Bottomley
2009-08-11 16:49     ` Joe Perches
2009-08-09 19:54 ` [PATCH 13/14] vsprintf: use WARN_ON_ONCE Marcin Slusarz
2009-08-09 19:54 ` [PATCH 14/14] net: use printk_once Marcin Slusarz
2009-08-10  2:52   ` David Miller
2009-08-09 20:36 ` [PATCH 00/14] " Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada7hxba7lx.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=general@lists.openfabrics.org \
    --cc=jackm@dev.mellanox.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.